Skip to content

refactor(cli): collapse list to a concrete oclif command#2197

Merged
cv merged 4 commits intorefactor/oclif-list-native-help-errorsfrom
refactor/oclif-list-consolidation
Apr 21, 2026
Merged

refactor(cli): collapse list to a concrete oclif command#2197
cv merged 4 commits intorefactor/oclif-list-native-help-errorsfrom
refactor/oclif-list-consolidation

Conversation

@cv
Copy link
Copy Markdown
Contributor

@cv cv commented Apr 21, 2026

Summary

This stacked PR now builds on #2189 by collapsing nemoclaw list down to a single concrete oclif command and a small generic oclif runner helper. Because #2192 merged independently before this stack was fully rebased, the branch was refreshed against the latest #2189 head to keep the stack mergeable while preserving the same final list behavior.

Changes

  • Replace the generated createListCommand(...) path in src/lib/list-command.ts with a single exported ListCommand class that builds its own runtime dependencies via buildListCommandDeps().
  • Add src/lib/oclif-runner.ts so the legacy dispatcher can run registered oclif commands without keeping list-specific wrapper logic.
  • Simplify src/lib/list-command-deps.ts to return only the inventory dependencies actually needed by getSandboxInventory().
  • Update src/lib/oclif-commands.ts and src/nemoclaw.ts to use the concrete command class and the generic oclif runner.
  • Remove src/lib/list-command.test.ts; the remaining inventory unit tests plus CLI integration tests cover the list behavior directly.
  • Refresh the branch against the latest refactor(cli): let oclif own list help and parse errors #2189 head after refactor(cli): move list command deps into a dedicated module #2192 landed separately, so GitHub can merge the stack cleanly.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • make docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

AI Disclosure

  • AI-assisted — tool: OpenAI Codex

Signed-off-by: Carlos Villela cvillela@nvidia.com

cv added 2 commits April 21, 2026 10:36
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv self-assigned this Apr 21, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 41c0e6e6-98b3-4b28-b489-b41a0da3e3e5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/oclif-list-consolidation

Comment @coderabbitai help to get the list of available commands and usage tips.

@cv cv changed the base branch from refactor/list-command-deps-module to refactor/oclif-list-native-help-errors April 21, 2026 18:48
@cv cv merged commit f3eba5f into refactor/oclif-list-native-help-errors Apr 21, 2026
8 checks passed
@cv cv added the v0.0.22 Release target label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v0.0.22 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant