refactor(cli): collapse list to a concrete oclif command#2197
Merged
cv merged 4 commits intorefactor/oclif-list-native-help-errorsfrom Apr 21, 2026
Merged
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This stacked PR now builds on #2189 by collapsing
nemoclaw listdown to a single concrete oclif command and a small generic oclif runner helper. Because #2192 merged independently before this stack was fully rebased, the branch was refreshed against the latest #2189 head to keep the stack mergeable while preserving the same finallistbehavior.Changes
createListCommand(...)path insrc/lib/list-command.tswith a single exportedListCommandclass that builds its own runtime dependencies viabuildListCommandDeps().src/lib/oclif-runner.tsso the legacy dispatcher can run registered oclif commands without keeping list-specific wrapper logic.src/lib/list-command-deps.tsto return only the inventory dependencies actually needed bygetSandboxInventory().src/lib/oclif-commands.tsandsrc/nemoclaw.tsto use the concrete command class and the generic oclif runner.src/lib/list-command.test.ts; the remaining inventory unit tests plus CLI integration tests cover the list behavior directly.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)AI Disclosure
Signed-off-by: Carlos Villela cvillela@nvidia.com