docs: document policy path for host services (#1551)#2593
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughAdds documentation clarifying how a sandbox should reach HTTP services on the host via the OpenShell gateway and NemoClaw network policy preset workflow; includes CLI commands, diagnostic steps, and explicit warnings against using host-specific shortcuts that bypass OpenShell policy enforcement. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (4)
.agents/skills/nemoclaw-user-reference/references/troubleshooting.md (1)
739-739: Use active voice instead of passive.Line 739: "After the policy is applied" uses passive voice.
Rewrite to active voice.As per coding guidelines, "Active voice required. Flag passive constructions."
✏️ Suggested revision
-After the policy is applied, retry the request from inside the sandbox without disabling the proxy: +After applying the policy, retry the request from inside the sandbox without disabling the proxy:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/skills/nemoclaw-user-reference/references/troubleshooting.md at line 739, Replace the passive phrase "After the policy is applied" with an active-voice construction (e.g., "After you apply the policy") in the sentence that begins "After the policy is applied, retry the request from inside the sandbox without disabling the proxy"; ensure the updated sentence uses active voice and retains the original meaning and instructions.docs/reference/troubleshooting.md (1)
769-769: Use active voice instead of passive.Line 769: "After the policy is applied" uses passive voice.
Rewrite to active voice.As per coding guidelines, "Active voice required. Flag passive constructions."
✏️ Suggested revision
-After the policy is applied, retry the request from inside the sandbox without disabling the proxy: +After applying the policy, retry the request from inside the sandbox without disabling the proxy:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/reference/troubleshooting.md` at line 769, The sentence uses passive voice ("After the policy is applied"); rewrite it in active voice by replacing that phrase with an active construction such as "After you apply the policy" or "Once you apply the policy" so the full sentence reads e.g. "After you apply the policy, retry the request from inside the sandbox without disabling the proxy." Locate the exact text "After the policy is applied, retry the request from inside the sandbox without disabling the proxy:" and update it accordingly.docs/network-policy/customize-network-policy.md (1)
30-34: Split line 31 into separate sentences for diff readability.Line 31 contains two sentences on one line.
The style guide requires one sentence per line in source for readable diffs.As per coding guidelines, "One sentence per line in source (makes diffs readable). Flag paragraphs where multiple sentences appear on the same line."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/network-policy/customize-network-policy.md` around lines 30 - 34, The note block containing "If the sandbox needs to reach an HTTP service running on the host, expose the service on a host IP that the OpenShell gateway can reach and apply a custom NemoClaw preset with `nemoclaw <sandbox> policy-add --from-file`." has two sentences on the same source line; split that line into two separate lines so each sentence is on its own line to satisfy the "one sentence per line" style rule—edit the note paragraph (the block beginning with "If the sandbox needs to reach an HTTP service running on the host...") and break the combined sentence into two lines, preserving wording and punctuation..agents/skills/nemoclaw-user-manage-policy/SKILL.md (1)
77-79: Split line 77 into separate sentences for diff readability.Line 77 contains two sentences on one line.
The style guide requires one sentence per line in source.As per coding guidelines, "One sentence per line in source (makes diffs readable). Flag paragraphs where multiple sentences appear on the same line."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.agents/skills/nemoclaw-user-manage-policy/SKILL.md around lines 77 - 79, The paragraph in SKILL.md contains two sentences on the same line; split the combined sentence that starts "If the sandbox needs to reach an HTTP service running on the host, expose the service on a host IP that the OpenShell gateway can reach and apply a custom NemoClaw preset with `nemoclaw <sandbox> policy-add --from-file`." into two lines so each sentence is on its own line (keep the first sentence about exposing the service on a host IP and the second sentence about applying a custom NemoClaw preset), ensuring the existing wording and inline code (`nemoclaw <sandbox> policy-add --from-file`) remain unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.agents/skills/nemoclaw-user-manage-policy/SKILL.md:
- Around line 77-79: The paragraph in SKILL.md contains two sentences on the
same line; split the combined sentence that starts "If the sandbox needs to
reach an HTTP service running on the host, expose the service on a host IP that
the OpenShell gateway can reach and apply a custom NemoClaw preset with
`nemoclaw <sandbox> policy-add --from-file`." into two lines so each sentence is
on its own line (keep the first sentence about exposing the service on a host IP
and the second sentence about applying a custom NemoClaw preset), ensuring the
existing wording and inline code (`nemoclaw <sandbox> policy-add --from-file`)
remain unchanged.
In @.agents/skills/nemoclaw-user-reference/references/troubleshooting.md:
- Line 739: Replace the passive phrase "After the policy is applied" with an
active-voice construction (e.g., "After you apply the policy") in the sentence
that begins "After the policy is applied, retry the request from inside the
sandbox without disabling the proxy"; ensure the updated sentence uses active
voice and retains the original meaning and instructions.
In `@docs/network-policy/customize-network-policy.md`:
- Around line 30-34: The note block containing "If the sandbox needs to reach an
HTTP service running on the host, expose the service on a host IP that the
OpenShell gateway can reach and apply a custom NemoClaw preset with `nemoclaw
<sandbox> policy-add --from-file`." has two sentences on the same source line;
split that line into two separate lines so each sentence is on its own line to
satisfy the "one sentence per line" style rule—edit the note paragraph (the
block beginning with "If the sandbox needs to reach an HTTP service running on
the host...") and break the combined sentence into two lines, preserving wording
and punctuation.
In `@docs/reference/troubleshooting.md`:
- Line 769: The sentence uses passive voice ("After the policy is applied");
rewrite it in active voice by replacing that phrase with an active construction
such as "After you apply the policy" or "Once you apply the policy" so the full
sentence reads e.g. "After you apply the policy, retry the request from inside
the sandbox without disabling the proxy." Locate the exact text "After the
policy is applied, retry the request from inside the sandbox without disabling
the proxy:" and update it accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 09f1ba92-2342-486d-b489-145d28ced381
📒 Files selected for processing (4)
.agents/skills/nemoclaw-user-manage-policy/SKILL.md.agents/skills/nemoclaw-user-reference/references/troubleshooting.mddocs/network-policy/customize-network-policy.mddocs/reference/troubleshooting.md
ericksoa
left a comment
There was a problem hiding this comment.
Approved. This documents the supported OpenShell policy/proxy path for host-side HTTP services and avoids recommending the unreliable/direct bridge path that bypasses policy and audit. The docs and generated skill updates are consistent, and the existing checks are green.
<!-- markdownlint-disable MD041 --> ## Summary Document the recommended path for accessing host-side HTTP services from a NemoClaw sandbox through the normal OpenShell policy/proxy flow. This avoids recommending direct `host.docker.internal` access, which bypasses policy enforcement and may not be reachable in every sandbox runtime. ## Related Issue Fixes NVIDIA#1551 ## Changes - Add troubleshooting guidance for host-side HTTP services. - Show how to create a custom NemoClaw policy preset for a host IP and port. - Document applying that preset with `nemoclaw <sandbox> policy-add --from-file`. - Add a network-policy note that `host.docker.internal` should not be treated as a general host-service path. - Regenerate the generated `nemoclaw-user-*` agent skills from the docs. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [x] Doc only (includes code sample changes) ## Verification - [ ] `npx prek run --all-files` passes - [ ] `npm test` passes - [ ] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [x] Docs updated for user-facing behavior changes - [x] `make docs` builds without warnings (doc changes only) - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) ## AI Disclosure - [x] AI-assisted — tool: Codex <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added guidance for configuring sandbox agents to access HTTP services on the host via the platform's network/proxy path. * Included steps for creating and applying custom network policy presets to allow host-service access and verify policy application. * Added troubleshooting diagnostics to distinguish policy matches from gateway reachability failures, plus warnings against bypassing the proxy with special hostnames or global no-proxy workarounds. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- Signed-off-by: Yanyun Liao <yanyunl@nvidia.com>
Summary
Document the recommended path for accessing host-side HTTP services from a NemoClaw sandbox through the normal OpenShell policy/proxy flow. This avoids recommending direct
host.docker.internalaccess, which bypasses policy enforcement and may not be reachable in every sandbox runtime.Related Issue
Fixes #1551
Changes
nemoclaw <sandbox> policy-add --from-file.host.docker.internalshould not be treated as a general host-service path.nemoclaw-user-*agent skills from the docs.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)AI Disclosure
Summary by CodeRabbit
Signed-off-by: Yanyun Liao yanyunl@nvidia.com