refactor(cli): extract maintenance image helpers

[cv]

Summary

Extract pure Docker image parsing and orphan-selection logic from the subprocess-heavy maintenance action module.

Stack Navigation

• Position: 47 of 60
• Previous PR: #2961 — test(cli): stabilize coverage dist sourcemaps
• Next PR: #2963 — refactor(cli): extract upgrade sandbox helpers

Changes

• Added maintenance-image-helpers.ts for Docker image row parsing and registered image-tag comparison.
• Updated garbageCollectImages to use the extracted helpers while keeping Docker/prompt orchestration in maintenance-actions.ts.
• Added direct helper coverage for image parsing, registered tag collection, and orphan detection.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• npm test passes
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes
• make docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• Refactor

  • Improved internal image maintenance operations with restructured logic for orphaned image detection and cleanup.

• Tests

  • Added comprehensive test coverage for image maintenance utilities, including image parsing, tag registration, and orphan detection.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2b0b3582-062e-430c-8f7c-c3c38c6686ba

📥 Commits

Reviewing files that changed from the base of the PR and between e7e73c1 and 151abad.

📒 Files selected for processing (3)

• src/lib/maintenance-actions.ts
• src/lib/maintenance-image-helpers.test.ts
• src/lib/maintenance-image-helpers.ts

---

📝 Walkthrough

Walkthrough

A new maintenance utilities module is introduced with three helper functions for parsing sandbox images and identifying orphaned images. The existing garbageCollectImages function is refactored to delegate image parsing and orphan detection to these new utilities, removing duplicated logic.

Changes

Image Maintenance Refactoring

Layer / File(s)	Summary
Type & Helper Functions src/lib/maintenance-image-helpers.ts	Introduces SandboxImageRow type and three helpers: parseSandboxImageRows() parses tab-separated image data into rows with size defaulting to "unknown"; getRegisteredImageTags() builds a Set of non-null imageTag values from sandboxes; findOrphanedSandboxImages() compares parsed images against registered tags to identify orphaned entries.
Refactoring Integration src/lib/maintenance-actions.ts	garbageCollectImages() is refactored to use parseSandboxImageRows() for initial parsing and findOrphanedSandboxImages() for orphan detection, removing manual image row parsing and local orphan-filter logic.
Tests src/lib/maintenance-image-helpers.test.ts	Unit tests verify parseSandboxImageRows() handles tab-separated rows with missing sizes, getRegisteredImageTags() extracts non-null imageTag values into a Set, and findOrphanedSandboxImages() correctly identifies images not in the registered tag set.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 Orphaned images once scattered and lost,
Now parsed with precision, sorted with cost,
Helpers extracted, logic made clean,
Maintenance flows clearer than ever we've seen! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/retry-maintenance-image-helpers

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[prekshivyas]

LGTM. Clean three-helper extraction — 3 files / +85 / -16.

Three pure functions (parseSandboxImageRows, getRegisteredImageTags, findOrphanedSandboxImages) extracted from garbageCollectImages into maintenance-image-helpers.ts. Inline parsing/filter blocks fully replaced by the helper calls. Same parsing rules (tab-split, missing-size default "unknown", empty-line drop), same orphan filter. Zero behavior change.

+43 lines of direct unit tests covering parsing edge cases (empty lines, missing size), registered-tag collection (handles null/missing imageTag), and orphan filter.

CI: pr.yaml mostly green (lint/dco/check-hash/legacy-path-guard/changes PASS); macos-e2e/checks + pr-self-hosted builds still in flight at review time. No failures.