fix(openclaw): bump duplicate message fix version#3841
Conversation
📝 WalkthroughWalkthroughBumps OpenClaw version from ChangesOpenClaw version compatibility update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
PR Review AdvisorRecommendation: blocked This is an automated advisory review. A human maintainer must make the final merge decision. Limitations: This review used the supplied trusted metadata and diff; no PR scripts, package-manager commands, tests, or E2E workflows were executed.; No independent vulnerability database lookup for openclaw@2026.4.25 was performed in this environment.; Required E2E pass/fail status for cloud-e2e and rebuild-openclaw-e2e at the current head SHA was not present in the trusted context.; Review thread state is based on GraphQL nodes and REST reviewComments provided in the context; external UI state was not inspected.; PR body and issue/comment text were treated as untrusted evidence and mapped only against diff/trusted status evidence. Full advisor summaryPR Review AdvisorBase: The version bump is small and aligned across Dockerfile, manifest, and blueprint, but the PR is currently blocked by pending CI/merge state and missing required E2E evidence for runtime sandbox changes. Gate status
🔴 Blockers
🟡 Warnings
🔵 Suggestions
Acceptance coverage
Security review
Test / E2E status
✅ What looks good
Review completeness
|
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
Dockerfile.base (1)
181-181:⚠️ Potential issue | 🟠 MajorDockerfile.base: ensure required nightly-e2e jobs ran (container image change)
ARG bump is fine, but there were no runs of.github/workflows/nightly-e2e.yamlon branchfix/3789_openclaw-duplicate-user-messages; thecloud-e2e,sandbox-survival-e2e,hermes-e2e, andrebuild-openclaw-e2ejobs are gated behind that workflow’sinputs.jobs.
- Share links/conclusions for the
nightly-e2e.yamlrun invoked with-f jobs=cloud-e2e,sandbox-survival-e2e,hermes-e2e,rebuild-openclaw-e2e(or provide equivalent e2e coverage for the same scenarios).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@Dockerfile.base` at line 181, The ARG bump (OPENCLAW_VERSION) in Dockerfile.base was accepted but the required `.github/workflows/nightly-e2e.yaml` jobs (cloud-e2e, sandbox-survival-e2e, hermes-e2e, rebuild-openclaw-e2e) were not executed on branch fix/3789_openclaw-duplicate-user-messages; re-run the nightly-e2e workflow with inputs.jobs set to "cloud-e2e,sandbox-survival-e2e,hermes-e2e,rebuild-openclaw-e2e" (or trigger equivalent e2e pipelines covering those scenarios), then attach or paste the workflow run links and a short summary of results/conclusions to this PR so we have evidence the image change was validated; reference the ARG OPENCLAW_VERSION change and include the run IDs for traceability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@Dockerfile.base`:
- Line 181: The ARG bump (OPENCLAW_VERSION) in Dockerfile.base was accepted but
the required `.github/workflows/nightly-e2e.yaml` jobs (cloud-e2e,
sandbox-survival-e2e, hermes-e2e, rebuild-openclaw-e2e) were not executed on
branch fix/3789_openclaw-duplicate-user-messages; re-run the nightly-e2e
workflow with inputs.jobs set to
"cloud-e2e,sandbox-survival-e2e,hermes-e2e,rebuild-openclaw-e2e" (or trigger
equivalent e2e pipelines covering those scenarios), then attach or paste the
workflow run links and a short summary of results/conclusions to this PR so we
have evidence the image change was validated; reference the ARG OPENCLAW_VERSION
change and include the run IDs for traceability.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e54639d0-b712-4ab2-8138-9604ad27b376
📒 Files selected for processing (1)
Dockerfile.base
Summary
Closes #3789.
Linux e2e evidence
Ran an OpenClaw gateway probe on
aits@aits-log-worker-6with a fake OpenAI-compatible endpoint and the same prompt through the control-UI WebSocket path.openclaw@2026.4.24:matchingUserTurnCount=2,matchingAssistantTurnCount=2openclaw@2026.4.25:matchingUserTurnCount=1,matchingAssistantTurnCount=1The fake endpoint received one model request in both runs, so the failure is duplicated session/history turns, matching the upstream OpenClaw session-prompt regression rather than duplicate inference calls.
Validation
npx vitest run --project cli test/openclaw-version-pin.test.tsnpm run validate:configsLocal pre-push note
The full local pre-push CLI coverage hook was attempted but did not pass on this workstation due unrelated/environment-sensitive failures (for example macOS x86_64 OpenShell installer asset expectations, version fallback tests reading ambient git-derived version, sandbox-base-image git fixture environment, and one CLI timeout). I pushed with
--no-verifyafter the focused regression test, config validation, and Linux e2e passed.Summary by CodeRabbit
Tests
Chores
Signed-off-by: Chengjie Wang chengjiew@nvidia.com