ci(e2e): add scenario run-all workflow#3920
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRefactors e2e-scenarios.yaml to accept workflow_call inputs (scenario, suite_filter, optional NVIDIA_API_KEY), replaces manual-event input references with inputs.*, updates WSL and non-WSL env/ifs, and adds e2e-scenarios-all.yaml to fan out predefined scenarios to the reusable workflow. ChangesE2E Scenario Workflow Reusability and Orchestration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
PR Review AdvisorRecommendation: blocked This is an automated advisory review. A human maintainer must make the final merge decision. Limitations: Review used trusted deterministic PR context plus read-only inspection of the changed files; no tests, scripts, package-manager commands, or workflows were executed.; GitHub status information is a snapshot and showed multiple checks still pending/in progress for the requested head SHA.; No linked issues were present, so acceptance mapping is limited to PR body clauses and comments provided in the trusted context.; E2E Advisor comment exists, but current-head E2E recommendation was still IN_PROGRESS in the status rollup, so E2E completion for ba32152 is not verified. Full advisor summaryPR Review AdvisorBase: Workflow/security fixes look directionally good, but the PR is not merge-ready because current-head CI is pending, mergeability is blocked, and run-all coverage/tests do not yet prove the claimed full scenario fan-out. Gate status
🔴 Blockers
🟡 Warnings
🔵 Suggestions
Acceptance coverage
Security review
Test / E2E status
✅ What looks good
Review completeness
|
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/e2e-scenarios-all.yaml:
- Around line 26-31: Replace the broad secrets: inherit in each scenario job
(e.g., job ubuntu-repo-cloud-openclaw) in
.github/workflows/e2e-scenarios-all.yaml with an explicit secrets mapping that
only passes NVIDIA_API_KEY as declared by the reusable workflow contract in
e2e-scenarios.yaml; update all seven job blocks (the ones using
./.github/workflows/e2e-scenarios.yaml) to use a secrets: block that maps
NVIDIA_API_KEY: ${{ secrets.NVIDIA_API_KEY }} instead of inheriting every
secret.
In @.github/workflows/e2e-scenarios.yaml:
- Around line 89-95: Update the "Set up Node" step that currently uses the
mutable tag actions/setup-node@v6 and pin it to the known full commit SHA used
elsewhere (for example
actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e) to remove
supply-chain risk; edit the workflow step named "Set up Node" and replace the
uses value actions/setup-node@v6 with the full commit SHA, and make the
identical change in the other listed workflows (e2e-parity-compare.yaml,
e2e-branch-validation.yaml, e2e-advisor.yaml, nightly-e2e.yaml,
commit-lint.yaml).
- Around line 108-115: The workflow directly interpolates inputs.scenario into
the run script which allows shell injection; instead, export the input into the
step environment and reference it as a quoted shell variable. For the non-WSL
step that calls bash test/e2e/runtime/run-scenario.sh and the WSL step that uses
the PowerShell heredoc, add an env entry such as SCENARIO: ${{ inputs.scenario
}} and change the run lines to invoke the script with a quoted variable
("$SCENARIO" in bash, "$env:SCENARIO" or equivalent in PowerShell), so all
occurrences of ${ { inputs.scenario } } in the run blocks are replaced by the
safe env variable reference. Ensure both the step that runs run-scenario.sh and
the WSL heredoc section are updated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a0c321e2-6d69-46ba-8da6-da263a4e0dba
📒 Files selected for processing (2)
.github/workflows/e2e-scenarios-all.yaml.github/workflows/e2e-scenarios.yaml
cv
approved these changes
May 20, 2026
…runner # Conflicts: # .github/workflows/e2e-scenarios.yaml
cv
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Follow-up
Summary by CodeRabbit
New Features
Chores
Tests