fix(onboard): make step 3 banner provider-agnostic

[Dongni-Yang]

Summary

The step 3 onboard banner printed Configuring inference (NIM) before the user picked a provider, so the (NIM) qualifier appeared for OpenAI, Anthropic, Gemini, Ollama, and every other non-NIM selection. Switch the label to Configuring inference provider, matching the wording already used by the blueprint runner (nemoclaw/src/blueprint/runner.ts:736) and the e2e harness.

Related Issue

Closes #3951

Changes

• src/lib/onboard.ts: rename the step 3 banner inside setupNim() from Configuring inference (NIM) to Configuring inference provider.
• src/lib/onboard.ts: update ONBOARD_STEP_INDEX.provider_selection.title so the resume / reuse banner stays consistent with the live banner.
• test/onboard-selection.test.ts: add two regression assertions on the captured stdout of setupNim() — the new banner must appear and (NIM) must not, when a non-NIM provider is selected.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Verification

• npx prek run --all-files passes
• Targeted vitest project run: vitest run --project cli test/onboard-selection.test.ts test/onboard.test.ts test/onboard-resume-provider-recovery.test.ts — 125 tests, all pass
• Tests added or updated for new or changed behavior
• No secrets, API keys, or credentials committed
• Docs updated for user-facing behavior changes

---

Signed-off-by: Dongni Yang dongniy@nvidia.com

Summary by CodeRabbit

• Style

  • Updated the "Configuring inference provider" onboarding step label to use provider-agnostic terminology.

• Tests

  • Added test assertions to verify the inference provider selection step uses provider-agnostic labeling.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b65b088b-74e5-4185-95cb-4c45fc975886

📥 Commits

Reviewing files that changed from the base of the PR and between dc63189 and f7ccf83.

📒 Files selected for processing (2)

• src/lib/onboard.ts
• test/onboard-selection.test.ts

---

📝 Walkthrough

Walkthrough

During onboarding, step [3/8] displays a banner label. This PR changes the label from "Configuring inference (NIM)" to "Configuring inference provider" to reflect that any inference provider can be selected, not just NIM-local backends. The step title constant and runtime label are updated together, and a UX test assertion is added to enforce the provider-agnostic label.

Changes

Onboarding inference provider label

Layer / File(s)	Summary
Provider-agnostic step label src/lib/onboard.ts, test/onboard-selection.test.ts	Step [3/8] label changed from "Configuring inference (NIM)" to "Configuring inference provider" in both setupNim() and ONBOARD_STEP_INDEX.provider_selection.title. Test assertions verify the banner is provider-agnostic and does not contain "(NIM)".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

fix, NemoClaw CLI

Suggested reviewers

• cv
• ericksoa

Poem

🐰 The banner once said "NIM" with pride,
But all providers deserve their guide!
Now step [3/8] speaks truth so clear—
"Configuring inference" for every provider here! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: making the step 3 onboarding banner provider-agnostic instead of NIM-specific.
Linked Issues check	✅ Passed	The PR fully addresses issue #3951 by changing the step 3 banner from 'Configuring inference (NIM)' to 'Configuring inference provider' and adding test assertions to verify the fix.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the provider-agnostic banner issue: updating labels in onboard.ts and adding targeted test assertions in onboard-selection.test.ts.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}