test: tolerate OpenClaw JSON envelope changes#4038
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughAdds a shared ChangesOpenClaw JSON Parsing Consolidation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (4)
test/e2e/test-messaging-compatible-endpoint.sh (1)
40-41: Run the messaging-compatible endpoint nightly lane for this change.Please run:
gh workflow run nightly-e2e.yaml --ref <branch> -f jobs=messaging-compatible-endpoint-e2eAs per coding guidelines,
test/e2e/test-messaging-compatible-endpoint.shrecommendsmessaging-compatible-endpoint-e2e.Also applies to: 530-530
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/test-messaging-compatible-endpoint.sh` around lines 40 - 41, The PR needs the nightly messaging-compatible-endpoint E2E lane run; trigger the GitHub Actions workflow for this branch by running: gh workflow run nightly-e2e.yaml --ref <branch> -f jobs=messaging-compatible-endpoint-e2e, ensuring you use the branch name for this PR and confirm the job name matches the test/e2e/test-messaging-compatible-endpoint.sh recommendation (messaging-compatible-endpoint-e2e); if the workflow is missing, add or update the nightly-e2e.yaml to include that job before triggering.test/e2e/test-openclaw-inference-switch.sh (1)
296-297: Run the inference-switch nightly lane after migrating to the shared parser.Please run:
gh workflow run nightly-e2e.yaml --ref <branch> -f jobs=openclaw-inference-switch-e2eAs per coding guidelines,
test/e2e/test-openclaw-inference-switch.shrecommendsopenclaw-inference-switch-e2e.Also applies to: 277-277
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/test-openclaw-inference-switch.sh` around lines 296 - 297, The test suite file test-openclaw-inference-switch.sh should trigger the new nightly job after migrating to the shared parser; run the GitHub Actions workflow with the command gh workflow run nightly-e2e.yaml --ref <branch> -f jobs=openclaw-inference-switch-e2e (replace <branch> with your branch) so the openclaw-inference-switch-e2e lane is executed; confirm the job runs and update any CI docs or PR description to note the nightly invocation for test-openclaw-inference-switch.sh.test/e2e/test-bedrock-runtime-compatible-anthropic.sh (1)
28-29: Run the dedicated Bedrock-compatible E2E lane for this parser migration.Please run:
gh workflow run nightly-e2e.yaml --ref <branch> -f jobs=bedrock-runtime-compatible-anthropic-e2e
to validate this path end-to-end after switching to the shared JSON parser.As per coding guidelines,
test/e2e/test-bedrock-runtime-compatible-anthropic.shrecommends runningbedrock-runtime-compatible-anthropic-e2e.Also applies to: 703-703
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/test-bedrock-runtime-compatible-anthropic.sh` around lines 28 - 29, The test script test/e2e/test-bedrock-runtime-compatible-anthropic.sh recommends running the dedicated Bedrock-compatible E2E lane but the PR hasn't validated it; run the nightly workflow for that lane to validate the shared JSON parser path by executing: gh workflow run nightly-e2e.yaml --ref <branch> -f jobs=bedrock-runtime-compatible-anthropic-e2e (replace <branch> with your branch), then confirm the job completed successfully and attach the run link or results to the PR so the bedrock-runtime-compatible-anthropic-e2e path is verified.test/e2e/test-full-e2e.sh (1)
72-73: Run the two nightly lanes tied to this full onboard path.Please run:
gh workflow run nightly-e2e.yaml --ref <branch> -f jobs=cloud-e2e,openclaw-onboard-security-posture-e2eAs per coding guidelines,
test/e2e/test-full-e2e.shrecommendscloud-e2eandopenclaw-onboard-security-posture-e2e.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/e2e/test-full-e2e.sh` around lines 72 - 73, Update the E2E run to trigger the two nightly lanes for the full onboard path: from the test script (test-full-e2e.sh) invoke the GitHub workflow "nightly-e2e.yaml" for your branch using the GitHub CLI and specify jobs=cloud-e2e and jobs=openclaw-onboard-security-posture-e2e (i.e., run the workflow with gh workflow run nightly-e2e.yaml --ref <branch> -f jobs=cloud-e2e,openclaw-onboard-security-posture-e2e) so the cloud-e2e and openclaw-onboard-security-posture-e2e lanes are executed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/e2e/test-bedrock-runtime-compatible-anthropic.sh`:
- Around line 28-29: The test script
test/e2e/test-bedrock-runtime-compatible-anthropic.sh recommends running the
dedicated Bedrock-compatible E2E lane but the PR hasn't validated it; run the
nightly workflow for that lane to validate the shared JSON parser path by
executing: gh workflow run nightly-e2e.yaml --ref <branch> -f
jobs=bedrock-runtime-compatible-anthropic-e2e (replace <branch> with your
branch), then confirm the job completed successfully and attach the run link or
results to the PR so the bedrock-runtime-compatible-anthropic-e2e path is
verified.
In `@test/e2e/test-full-e2e.sh`:
- Around line 72-73: Update the E2E run to trigger the two nightly lanes for the
full onboard path: from the test script (test-full-e2e.sh) invoke the GitHub
workflow "nightly-e2e.yaml" for your branch using the GitHub CLI and specify
jobs=cloud-e2e and jobs=openclaw-onboard-security-posture-e2e (i.e., run the
workflow with gh workflow run nightly-e2e.yaml --ref <branch> -f
jobs=cloud-e2e,openclaw-onboard-security-posture-e2e) so the cloud-e2e and
openclaw-onboard-security-posture-e2e lanes are executed.
In `@test/e2e/test-messaging-compatible-endpoint.sh`:
- Around line 40-41: The PR needs the nightly messaging-compatible-endpoint E2E
lane run; trigger the GitHub Actions workflow for this branch by running: gh
workflow run nightly-e2e.yaml --ref <branch> -f
jobs=messaging-compatible-endpoint-e2e, ensuring you use the branch name for
this PR and confirm the job name matches the
test/e2e/test-messaging-compatible-endpoint.sh recommendation
(messaging-compatible-endpoint-e2e); if the workflow is missing, add or update
the nightly-e2e.yaml to include that job before triggering.
In `@test/e2e/test-openclaw-inference-switch.sh`:
- Around line 296-297: The test suite file test-openclaw-inference-switch.sh
should trigger the new nightly job after migrating to the shared parser; run the
GitHub Actions workflow with the command gh workflow run nightly-e2e.yaml --ref
<branch> -f jobs=openclaw-inference-switch-e2e (replace <branch> with your
branch) so the openclaw-inference-switch-e2e lane is executed; confirm the job
runs and update any CI docs or PR description to note the nightly invocation for
test-openclaw-inference-switch.sh.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f1bc1ef0-bfda-476d-823b-64ee47950bea
📒 Files selected for processing (8)
test/e2e/lib/openclaw-json.shtest/e2e/test-bedrock-runtime-compatible-anthropic.shtest/e2e/test-brave-search-e2e.shtest/e2e/test-full-e2e.shtest/e2e/test-launchable-smoke.shtest/e2e/test-messaging-compatible-endpoint.shtest/e2e/test-openclaw-inference-switch.shtest/e2e/test-sandbox-operations.sh
Selective E2E Results — ✅ All requested jobs passedRun: 26263753126
|
3 participants
Summary
openclaw agent --jsonresult.payloads[]and current top-levelpayloads[]envelopes, plus common nested content shapesValidation
bash -n test/e2e/lib/openclaw-json.sh test/e2e/test-messaging-compatible-endpoint.sh test/e2e/test-brave-search-e2e.sh test/e2e/test-launchable-smoke.sh test/e2e/test-sandbox-operations.sh test/e2e/test-openclaw-inference-switch.sh test/e2e/test-bedrock-runtime-compatible-anthropic.sh test/e2e/test-full-e2e.shpayloads[], legacyresult.payloads[], prefixed JSON, and OpenAI-stylechoices[].message.contentgit diff --checkFixes the false negative seen in messaging-compatible-endpoint C8 where the agent returned PONG in top-level
payloads[]but the test only parsedresult.payloads[].Summary by CodeRabbit