chore(ci): install NVSkills CI request listener for /nvskills-ci#4345
Conversation
Adds the team-request workflow from NVIDIA/nvskills-ci so PR comments of `/nvskills-ci` (and signature push events from `nv-skills-ci[bot]`) are forwarded to the central NVSkills CI service. Without this listener, `/nvskills-ci` comments on the catalog refresh PR (#4344 and successors) are no-ops and signing artifacts (`skill.oms.sig`, `skill-card.md`) are never pushed back, leaving merged refresh PRs unsigned. Completes NVIDIA/nvskills-ci team-onboarding steps 2 and 4 for NemoClaw: - `.github/workflows/request-nvskills-ci.yml`: copied byte-for-byte from templates/team-request-workflow.yml@main, with a NemoClaw SPDX header. Triggers `NVIDIA/skills/.github/workflows/team-request.yml@main` via `secrets.NVSKILLS_CI_DISPATCH_TOKEN`. - `.github/CODEOWNERS`: explicitly require nemoclaw-maintainer review on the new workflow file (CODEOWNERS protection is required by onboarding step 4); also fix the now-stale `/skills/nemoclaw/` rule to `/skills/` to match the flattened export layout from #4342. Onboarding step 3 (set the `NVSKILLS_CI_DISPATCH_TOKEN` repo secret) must be completed by a maintainer/admin via repo settings before the listener can dispatch successfully. Until that secret is set, runs of this workflow will fail at the secrets-injection boundary. Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughBroadens CODEOWNERS to explicitly cover ChangesNVSkills CI Integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
E2E Scenario Advisor RecommendationRequired scenario E2E: None Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
PR Review AdvisorFindings: 1 needs attention, 4 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/request-nvskills-ci.yml:
- Line 32: The workflow currently references the reusable workflow as
NVIDIA/skills/.github/workflows/team-request.yml@main which is unpinned; replace
the `@main` ref with a specific commit SHA (e.g., @<commit-sha>) to pin the
reusable workflow and remove the supply-chain risk. Locate the uses line that
contains "NVIDIA/skills/.github/workflows/team-request.yml@main" and update it
to the commit SHA you obtain from the upstream repo (you can fetch the main
branch HEAD commit via the upstream repo's API or git), then commit the change
and optionally add Dependabot config to keep the pinned action updated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8898ecbc-910f-44b6-a4b2-b4611e6da99e
📒 Files selected for processing (2)
.github/CODEOWNERS.github/workflows/request-nvskills-ci.yml
Summary
Install the NVSkills CI request listener so
/nvskills-cicomments on catalog refresh PRs actually trigger NVSkills signing. Without this listener, comments are no-ops and merged refresh PRs ship unsigned (which downstreamNVIDIA/skillsthen drops on sync).Related Issue
Follow-up to #4282 / #4342. Discovered while running the post-merge signing flow on PR #4344: the
/nvskills-cicomment posted on that PR produced no workflow run because NemoClaw was missing the team-request listener.Changes
.github/workflows/request-nvskills-ci.yml(new): copied byte-for-byte fromNVIDIA/nvskills-ci/templates/team-request-workflow.yml@main, with a NemoClaw SPDX header. Forwards/nvskills-ciPR comments (andnv-skills-ci[bot]signature pushes) toNVIDIA/skills/.github/workflows/team-request.yml@mainviasecrets.NVSKILLS_CI_DISPATCH_TOKEN..github/CODEOWNERS: add an explicit nemoclaw-maintainer rule for/.github/workflows/request-nvskills-ci.ymlso onboarding step 4 (CODEOWNERS protection) is visibly enforced; also flatten the now-stale/skills/nemoclaw/rule to/skills/to match the post-fix(skills): flatten catalog export and detect untracked files in refresh diff #4342 export layout.Onboarding status
Per
NVIDIA/nvskills-ci/docs/team-onboarding.md:config/onboarded-repositories.jsontemplates/team-request-workflow.ymlas.github/workflows/request-nvskills-ci.ymlNVSKILLS_CI_DISPATCH_TOKENrepo secret/nvskills-cion a PRType of Change
Verification
Workflow body verified byte-identical to upstream template:
Listener is inert until the
NVSKILLS_CI_DISPATCH_TOKENsecret is set; until then/nvskills-cicomments will fail at the secret-injection boundary, but they will at least produce a visible failed workflow run instead of silently doing nothing.No secrets, API keys, or credentials committed
Tests added or updated for new or changed behavior — N/A (single workflow file mirrored from upstream template; behavior is exercised by the next live
/nvskills-cicomment)Docs updated for user-facing behavior changes — N/A (CI-internal)
npm run docsbuilds without warnings — N/ADoc pages follow the style guide — N/A
New doc pages include SPDX header and frontmatter — N/A
Signed-off-by: Justin Yaunches jyaunches@nvidia.com
Summary by CodeRabbit