Skip to content

refactor(onboard): add sequence runner adapter#4475

Draft
cv wants to merge 1 commit into
stack/onboard-fsm-runner-multi-resultfrom
stack/onboard-fsm-sequence-adapter
Draft

refactor(onboard): add sequence runner adapter#4475
cv wants to merge 1 commit into
stack/onboard-fsm-runner-multi-resultfrom
stack/onboard-fsm-sequence-adapter

Conversation

@cv
Copy link
Copy Markdown
Collaborator

@cv cv commented May 29, 2026

Summary

Add a sequence-runner adapter that can migrate the existing rich onboarding phases onto the strict FSM runner. Each phase can return an updated context plus one or more FSM results, while runOnboardMachine() remains responsible for applying and validating transitions.

Changes

  • Add runOnboardSequenceWithRunner() and buildOnboardSequenceHandlers().
  • Add duplicate phase detection for state-to-handler adapter construction.
  • Add sequence-runner tests covering rich context updates, multi-result provider-style phases, retry, branch, and terminal completion.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv self-assigned this May 29, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 29, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d4a6502d-50a1-455d-b117-a249280acb90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch stack/onboard-fsm-sequence-adapter

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: ubuntu-repo-cloud-openclaw, ubuntu-repo-cloud-openclaw-resume, ubuntu-repo-cloud-openclaw-repair

Dispatch hint: ubuntu-repo-cloud-openclaw,ubuntu-repo-cloud-openclaw-resume,ubuntu-repo-cloud-openclaw-repair

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/stack/onboard-fsm-runner-multi-result
Head: HEAD
Confidence: high

Required E2E

  • None. No merge-blocking E2E is required because the only runtime source change adds a new onboarding FSM adapter that is not currently imported by the CLI/user-flow implementation; the PR also adds focused unit coverage for the new helper. Existing user-facing onboarding, sandbox lifecycle, credentials, policy, and inference paths are not changed by this diff.

Optional E2E

  • ubuntu-repo-cloud-openclaw (medium): Optional smoke confidence for the adjacent onboarding path: verifies the current Ubuntu cloud OpenClaw onboarding scenario still completes, even though this new adapter is not yet wired into the user-facing flow.
  • ubuntu-repo-cloud-openclaw-resume (medium): Optional confidence for nearby FSM/session behavior because the new adapter handles retries and multi-result state progression, which is conceptually adjacent to onboarding resume behavior.
  • ubuntu-repo-cloud-openclaw-repair (medium): Optional confidence for nearby onboarding recovery behavior because the adapter is part of the migration toward strict state-machine-owned transitions.

New E2E recommendations

  • None.

Dispatch hint

  • Workflow: E2E / Scenario Runner
  • jobs input: ubuntu-repo-cloud-openclaw,ubuntu-repo-cloud-openclaw-resume,ubuntu-repo-cloud-openclaw-repair

@github-actions
Copy link
Copy Markdown
Contributor

E2E Scenario Advisor Recommendation

Required scenario E2E: None
Optional scenario E2E: None

Workflow run

Full scenario advisor summary

E2E Scenario Advisor

Base: origin/stack/onboard-fsm-runner-multi-result
Head: HEAD
Confidence: high

Required scenario E2E

  • None. No scenario workflow, scenario metadata, scenario runtime, or validation-suite files changed.

Optional scenario E2E

  • None.

Relevant changed files

  • None.

@github-actions
Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 0 worth checking, 0 nice ideas
Top item: No actionable code findings

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@cv cv added the onboarding Making the onboarding experience better label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

onboarding Making the onboarding experience better

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant