Skip to content

test(e2e): add first Vitest live smoke scenario#4967

Merged
jyaunches merged 6 commits into
mainfrom
codex/e2e-4941-stack-05-live-smoke
Jun 8, 2026
Merged

test(e2e): add first Vitest live smoke scenario#4967
jyaunches merged 6 commits into
mainfrom
codex/e2e-4941-stack-05-live-smoke

Conversation

@cv

@cv cv commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds the first opt-in live Vitest E2E scenario as a small repo-local CLI smoke test using the new fixtures. Stack PR 5/7. cc @jyaunches for review.

Related Issue

Refs #4941.

Changes

  • Adds test/e2e-scenario/live/ubuntu-repo-cli-smoke.test.ts as the first live scenario under the gated project.
  • Exercises node bin/nemoclaw.js --version through the scenario fixture command client.
  • Adds an explicit dist/nemoclaw.js build-prerequisite check so clean checkouts fail with an actionable message.
  • Updates scenario docs with npm run build:cli plus the opt-in live smoke command.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npm run build:cli
  • npx vitest run --project e2e-scenario-framework --silent=false --reporter=default
  • NEMOCLAW_RUN_E2E_SCENARIOS=1 npx vitest run --project e2e-scenarios-live test/e2e-scenario/live/ubuntu-repo-cli-smoke.test.ts --silent=false --reporter=default
  • npm run typecheck:cli
  • Commit and pre-push hooks passed
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

cv added 5 commits June 8, 2026 09:34
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv added the area: e2e End-to-end tests, nightly failures, or validation infrastructure label Jun 8, 2026
@cv cv self-assigned this Jun 8, 2026
@copy-pr-bot

copy-pr-bot Bot commented Jun 8, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cv cv requested a review from jyaunches June 8, 2026 16:42
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@cv, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 26 minutes and 2 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f11483c7-a207-443e-acd4-cbf0e0427b03

📥 Commits

Reviewing files that changed from the base of the PR and between ef6b905 and a9de12d.

📒 Files selected for processing (3)
  • test/e2e-scenario/docs/MIGRATION.md
  • test/e2e-scenario/docs/README.md
  • test/e2e-scenario/live/ubuntu-repo-cli-smoke.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/e2e-4941-stack-05-live-smoke

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • None. No existing E2E job is required because this PR only changes scenario documentation and adds an opt-in E2E test file; it does not change NemoClaw runtime/user-flow code, installer/onboarding behavior, sandbox lifecycle, credentials, policy boundaries, inference routing, or deployment logic.

Optional E2E

  • None.

New E2E recommendations

  • live-vitest-scenario-dispatch (medium): The new live Vitest scenario is not represented as a dispatchable scenario ID in the existing .github/workflows/e2e-scenarios.yaml typed scenario runner. If maintainers expect CI/advisor dispatch for this path, add workflow coverage or registry metadata for the opt-in live Vitest project.
    • Suggested test: Add a dispatchable CI entry for the e2e-scenarios-live Vitest project or register ubuntu-repo-cli-smoke in the scenario runner once this path is intended to be CI-addressable.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

E2E Scenario Advisor Recommendation

Required scenario E2E: ubuntu-repo-cloud-openclaw
Optional scenario E2E: None

Dispatch required scenario E2E:

  • gh workflow run e2e-scenarios.yaml --ref <pr-head-ref> --field scenarios=ubuntu-repo-cloud-openclaw

Workflow run

Full scenario advisor summary

E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: medium

Required scenario E2E

  • ubuntu-repo-cloud-openclaw: The docs changes are informational, but the new opt-in live Vitest scenario targets an Ubuntu repo-local CLI smoke path. The closest dispatchable scenario route that exercises repo-current install on Ubuntu with CLI smoke coverage is ubuntu-repo-cloud-openclaw.
    • Dispatch: gh workflow run e2e-scenarios.yaml --ref <pr-head-ref> --field scenarios=ubuntu-repo-cloud-openclaw

Optional scenario E2E

  • None.

Relevant changed files

  • test/e2e-scenario/docs/MIGRATION.md
  • test/e2e-scenario/docs/README.md
  • test/e2e-scenario/live/ubuntu-repo-cli-smoke.test.ts

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor

Findings: 0 needs attention, 0 worth checking, 0 nice ideas
Since last review: 1 prior item resolved, 0 still apply, 0 new items found

Consider writing more tests for

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

@cv cv added the v0.0.62 Release target label Jun 8, 2026
Base automatically changed from codex/e2e-4941-stack-04-clients to main June 8, 2026 23:05
@wscurran wscurran added the chore Build, CI, dependency, or tooling maintenance label Jun 8, 2026
@cv cv marked this pull request as ready for review June 8, 2026 23:15
@jyaunches jyaunches merged commit 8f4fa7e into main Jun 8, 2026
49 of 50 checks passed
@jyaunches jyaunches deleted the codex/e2e-4941-stack-05-live-smoke branch June 8, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: e2e End-to-end tests, nightly failures, or validation infrastructure chore Build, CI, dependency, or tooling maintenance v0.0.62 Release target

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants