feat: support quick-start object storage secret refs#982
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe quick-start Helm chart now supports using Kubernetes Secrets for object storage credentials. A new ChangesKubernetes Secret Support for Object Storage Credentials
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
Description
Fixes #723.
Adds quick-start chart support for sourcing object storage access keys from an existing Kubernetes Secret instead of rendering them as plain Helm values in the
config-setupJob manifest.New values:
When
existingSecret.nameis set,OBJECT_STORAGE_ACCESS_KEY_IDandOBJECT_STORAGE_ACCESS_KEYusevalueFrom.secretKeyRef. When it is unset, the chart preserves the existingvalue:behavior for backward compatibility.Why
The quick-start chart previously required object storage secrets to be stored directly in values files. That exposes credentials in rendered manifests and Helm release secrets. This keeps the existing simple local defaults while allowing production deployments to provide credentials through Kubernetes Secrets.
Validation
helm lint deployments/charts/quick-starthelm template osmo deployments/charts/quick-start --show-only templates/config-setup.yamlhelm template osmo deployments/charts/quick-start --show-only templates/config-setup.yaml --set global.objectStorage.existingSecret.name=my-s3-secret --set global.objectStorage.existingSecret.accessKeyIdKey=access-key-id --set global.objectStorage.existingSecret.accessKeyKey=access-keykubectl apply --dry-run=server -f <rendered-config-setup>x3secretKeyRefshape; the pod verified both object storage environment variables and exited successfully. Temporary validation resources were deleted afterward.Checklist
Summary by CodeRabbit
New Features
Documentation