Vouch request: chrisyifanjin #4164
chrisyifanjin
started this conversation in
Vouch Request
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
What do you want to work on?
I am new to OpenShell and would like to work on a fix for #3942.
When two programs share a network rule, an update enabling
allow_uninspected_credentialsfor only one program can also give the other program that exception.My proposed change is in the Policy Engine here. We can add the missing flag comparison so the existing checks reject updates that don't explicitly declare all affected programs.
Why this change?
An update naming one program should not silently give another program extra permissions.
This fix makes this flag follow the same declaration checks as the other permission flags, while still allowing the exception when its scope is explicitly declared.
Checklist
All reactions