Skip to content

sec(server): validate environment key names for control characters in exec requests #594

@cluster2600

Description

@cluster2600

Summary

In `crates/openshell-server/src/grpc.rs` (line 3452), the `validate_exec_request_fields()` function applies `reject_control_chars()` to environment values but not to environment keys. Whilst keys come from the gRPC map (which limits exploitability), control characters in key names could cause unexpected behaviour in shell environments.

Impact

  • Severity: Low

Proposed Fix

Apply `reject_control_chars` to environment key names as well as values.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions