fix(cli): preserve directory basename for filtered uploads#1028
Merged
johntmyers merged 1 commit intomainfrom Apr 29, 2026
Merged
fix(cli): preserve directory basename for filtered uploads#1028johntmyers merged 1 commit intomainfrom
johntmyers merged 1 commit intomainfrom
Conversation
Signed-off-by: John Myers <johntmyers@users.noreply.github.com>
Contributor
|
Sorry for the noise on #976. My follow-up commit for the repo-backed/git-filtered path landed on my flag branch, not the PR branch John was reviewing. Thanks for carrying the #885 fix forward here. I fetched this PR locally at cc51dff and ran the focused upload coverage:
The behavior here matches the #885 production footgun we hit: named directory uploads preserve |
drew
approved these changes
Apr 29, 2026
drew
added a commit
that referenced
this pull request
Apr 29, 2026
PR #1028 (preserve directory basename for filtered uploads) changed the on-disk layout so that filtered directory uploads land under `<dest>/<basename>/...` rather than `<dest>/...`, matching the unfiltered upload semantics. The accompanying e2e test was not updated and now fails because it still expects `tracked.txt` directly under the download root. Update the assertions to look under the preserved `repo/` basename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make named directory uploads preserve the source directory basename consistently, including the default git-filtered upload path.
.gitignorefiltering now only decides which files are included; it no longer changes where those files land in the sandbox.Related Issue
Fixes #885
Changes
<dest>/<basename>/....upload .and file uploads.Testing
mise run pre-commitpassesChecklist