ci: add OS-49 phase 5 shadow workflows#1075
Conversation
e35be35 to
cc7340a
Compare
Signed-off-by: Jonas Toelke <jtoelke@nvidia.com>
cc7340a to
c5ff69c
Compare
|
@pimlock I addressed the remaining |
|
Overall question to make sure I understand what happens once this merges. All new PRs will now run the shadow checks as well as regular ones, so if something fails in the shadow check, it may block the PR from merging, right? Looking at this PR, it all looks good, just wanted to check. Also, for these new checks to run, the copy-pr-bot needs to mirror the pull request, so all the commits need to be signed, or the I think this is okay, alternative would be to guard the shadow infra behind a tag (which is what we do for the E2E already), but that's likely unnecessary here. |
|
Thanks, and yes, that matches my understanding with one important distinction: these shadow workflows will show up as PR checks, but they are not intended to be required checks for merge. I checked the current main ruleset and it does not require these shadow status checks. So if a shadow job fails, it should be visible/noisy, but it should not block the PR unless we later add it to required checks or decide as humans to hold the PR. For triggering: yes, the PR needs to be mirrored by copy-pr-bot into |
Summary
Add non-required OS-49 Phase 5 shadow workflows for branch checks, CI image builds, Branch E2E, and the reusable E2E test path on supported shared CPU runners.
Related Issue
Related to OS-129 / OS-49.
Changes
shadow-branch-checks.ymlonlinux-{amd64,arm64}-cpu8with trusted PR mirror validation and GHA-backed sccache.shadow-ci-image.ymlto build CI images natively per architecture with the local Buildx driver and no registry push.shadow-branch-e2e.ymlandshadow-e2e-test.ymlusing the existingtest:e2egate and shared arm64 runner.image-taginput todocker-build.ymlso shadow E2E publishes isolatedshadow-*tags.pr-gateusable for both label-gated E2E shadows and label-free copied-PR shadow workflows.mise lockcheck unconditionally so copied-PR push events cannot miss earliermise.toml/mise.lockchanges in the PR diff.shadow-ci-image.ymlso it always exercises copied PR pushes during the Phase 5 shadow bake.Testing
git diff --checkpassesmise x -- cargo test -p openshell-vfio --libpassesmise run pre-commitpasses with sanitized PATHmise lockpathtest:e2e/test:e2e-gpulabelsNote: an initial
mise run pre-commitwith the default WSL/Windows-heavy PATH failedssh::tests::launch_editor_returns_friendly_error_when_binary_missing; the isolated test and full pre-commit passed with Windows PATH entries removed.Checklist