feat(driver-docker): use host networking for sandboxes#1080
Merged
Conversation
15 tasks
cgwalters
reviewed
Apr 30, 2026
cgwalters
left a comment
There was a problem hiding this comment.
Just looking at the arch doc so far
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
28a8c31 to
0aee0f9
Compare
TaylorMutch
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out the Docker-driver networking changes from #1069. This PR keeps the gateway as a host process and runs Docker sandbox supervisor containers with Docker host networking so they can reach a gateway bound to
127.0.0.1without adding an extra bridge-reachable listener, proxy, or host/etc/hostschange on Linux.Related Issue
Split from #1069.
Changes
network_mode = "host"so supervisor callbacks can use loopback gateway endpoints directly.OPENSHELL_ENDPOINTexactly as configured for both plaintext and TLS gateway endpoints.host.openshell.internal -> 127.0.0.1hosts entry for a stable OpenShell-owned alias to host loopback services.Testing
mise run pre-commitpassesAdditional checks run:
cargo test -p openshell-driver-dockercargo fmt --all -- --checkmarkdownlint-cli2 architecture/docker-driver.md architecture/README.mdgit diff --checkKnown local test blocker:
mise run pre-commitgets through format, lint, markdown, Helm, Python, Rust check, and Clippy, then fails insandbox_create_keeps_sandbox_with_forwardingbecause Docker Desktop PID50455is already listening on local port8080.Checklist