Conversation
Replace 3 bash e2e test scripts with a standalone Rust crate (nemoclaw-e2e) that invokes the nemoclaw CLI as a subprocess. The new tests use a shared harness with RAII sandbox cleanup, ANSI output parsing, and TCP port utilities. Key decisions: - Standalone crate outside the workspace to avoid Dockerfile/Cargo.toml coupling - Feature-gated tests (--features e2e) so cargo test --workspace skips them - mise e2e:rust task builds the CLI binary before running tests - Simplified task structure: e2e, e2e:rust, e2e:python Closes #116
The Rust e2e tests invoke the nemoclaw CLI which shells out to ssh for sandbox exec, sync, and port forwarding. The CI container was missing openssh-client, causing 'No such file or directory' when the CLI tried to spawn the ssh process. Add openssh-client to Dockerfile.ci permanently and install it inline in the e2e workflow as an interim measure until the CI image is rebuilt.
drew
deleted the
anewberry/116-replace-bash-e2e-with-rust-integration-tests
branch
drew
added a commit
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #116
Summary
test_sandbox_custom_image.sh,test_sandbox_sync.sh,test_port_forward.sh) with a standalone Rust crate (nemoclaw-e2e) ate2e/rust/SandboxGuard), ANSI output parsing, binary resolution, and TCP port utilities--features e2esocargo test --workspaceskips them;mise run e2e:rustbuilds the CLI and runs the testse2e(all),e2e:rust,e2e:python