Skip to content

fix(ci): standardize safe tag fetches#165

Merged
pimlock merged 2 commits intomainfrom
chore/remove-redundant-tag-fetch
Mar 7, 2026
Merged

fix(ci): standardize safe tag fetches#165
pimlock merged 2 commits intomainfrom
chore/remove-redundant-tag-fetch

Conversation

@pimlock
Copy link
Collaborator

@pimlock pimlock commented Mar 7, 2026

Fixes https://github.com/NVIDIA/NemoClaw/actions/runs/22789880653/job/66114338702

Summary

  • keep explicit git fetch --tags --force steps in versioning jobs
  • mark $GITHUB_WORKSPACE as a safe Git directory before every manual tag fetch
  • apply the same checkout + safe-directory + tag-fetch pattern across Docker build and publish workflows

Why

We want one consistent pattern for version discovery in CI: full checkout history, an explicit tag refresh, and a safe workspace configuration before any manual Git command. Some jobs already marked the workspace safe, but the containerized Docker build jobs did not, which caused git fetch --tags --force to fail with Git's dubious ownership protection. This change keeps the explicit tag fetches and standardizes the required safety setup everywhere they run.

pimlock added 2 commits March 6, 2026 18:27
Standardize on actions/checkout with fetch-depth 0 for versioning data. This avoids manual git fetch calls that can fail in container jobs with dubious ownership while keeping tag discovery intact.
Keep explicit tag refreshes for versioning jobs, but always mark the GitHub workspace as safe first so container jobs do not fail with dubious ownership errors.
@pimlock pimlock changed the title fix(ci): remove redundant tag fetches fix(ci): standardize safe tag fetches Mar 7, 2026
@pimlock pimlock merged commit 26155bd into main Mar 7, 2026
10 checks passed
@pimlock pimlock deleted the chore/remove-redundant-tag-fetch branch March 7, 2026 02:58
drew pushed a commit that referenced this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant