fix(sandbox): opt Node clients into proxy env support#269
Merged
Conversation
drew
pushed a commit
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NODE_USE_ENV_PROXY=1alongside the existing proxy vars so Node's built-infetchandhttpclients actually honor the sandbox proxy configuration (see docs)Context
This came up while debugging OpenClaw onboarding inside a sandbox. OpenClaw's onboard flow validates a custom inference config with Node's built-in
fetch, and that request failed withfetch failedeven thoughcurlto the samehttps://inference.local/...endpoint succeeded.The root cause was that the sandbox already exported the proxy env vars, but Node does not honor them for built-in
fetch/httpclients unlessNODE_USE_ENV_PROXY=1is set at process startup. That made OpenClaw's onboarding path bypass the expected proxy behavior and fail in a way that was hard to diagnose.Related follow-up issue for better observability when traffic does not enter the normal proxy/logging path: #268.
Verification
mise run pre-commitcargo test -p navigator-sandbox apply_proxy_env_includes_node_proxy_opt_incargo test -p navigator-sandbox apply_tls_env_sets_node_and_bundle_pathscargo test -p navigator-sandbox apply_child_env_keeps_handshake_secret_out_of_ssh_childrencargo test -p navigator-sandbox scrub_sensitive_env_removes_ssh_handshake_secretcargo test -p navigator-sandbox inject_provider_env_sets_placeholder_valuesmise run sandbox(deploy completed, final sandbox creation step failed locally because providerclaudeis not configured)