fix(cli): show startup feedback for foreground forwards#296
Merged
Conversation
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
pimlock
commented
Mar 14, 2026
Comment on lines
+319
to
+320
| .arg("-o") | ||
| .arg("ExitOnForwardFailure=yes") |
Collaborator
Author
There was a problem hiding this comment.
With this, if the tunnel is not established for some reason (e.g. port is already used), it will exit. Currently it will hang after printing this:
openshell forward start 10001 peaceful-stinkbug
bind [::1]:10001: Address already in use
channel_setup_fwd_listener_tcpip: cannot listen to port: 10001
Could not request local forwarding.
# hangs
johntmyers
approved these changes
Mar 14, 2026
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
drew
pushed a commit
that referenced
this pull request
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #295
Summary
openshell forward startstays attachedExitOnForwardFailure=yesTest Plan
cargo test -p openshell-cli foreground_forward_started_message_includes_port_and_stop_hint -j 2uv syncmise run pre-commit