Skip to content

fix(cli): use --name flag in gateway destroy help messages#368

Merged
drew merged 1 commit intomainfrom
fix-gateway-destroy-help-commands/an
Mar 16, 2026
Merged

fix(cli): use --name flag in gateway destroy help messages#368
drew merged 1 commit intomainfrom
fix-gateway-destroy-help-commands/an

Conversation

@drew
Copy link
Collaborator

@drew drew commented Mar 16, 2026

Summary

Fix invalid gateway destroy commands in error messages and recovery hints. The CLI defines name as a --name flag, but all help messages were showing it as a positional argument, causing unexpected argument errors when users copied the suggested commands.

Changes

  • crates/openshell-bootstrap/src/errors.rs — Fix 7 occurrences of openshell gateway destroy {name} to openshell gateway destroy --name {name}
  • crates/openshell-cli/src/run.rs — Fix the "gateway not reachable" recovery hint
  • crates/openshell-bootstrap/src/lib.rs — Fix the "gateway already exists" error message

Testing

  • mise run pre-commit passes
  • cargo check passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Error messages and recovery hints were showing 'openshell gateway destroy <name>'
as a positional argument, but the CLI defines name as a --name flag. This caused
'unexpected argument' errors when users copied the suggested commands.
@drew drew self-assigned this Mar 16, 2026
@drew drew requested review from johntmyers and pimlock March 16, 2026 19:27
@drew drew merged commit 085b131 into main Mar 16, 2026
9 checks passed
@drew drew deleted the fix-gateway-destroy-help-commands/an branch March 16, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants