Skip to content

fix(deploy): remove duplicate glob pattern in manifest cleanup loop#428

Merged
drew merged 2 commits intoNVIDIA:mainfrom
leoshi01:fix/remove-duplicate-glob-pattern
Mar 18, 2026
Merged

fix(deploy): remove duplicate glob pattern in manifest cleanup loop#428
drew merged 2 commits intoNVIDIA:mainfrom
leoshi01:fix/remove-duplicate-glob-pattern

Conversation

@leoshi01
Copy link
Member

@leoshi01 leoshi01 commented Mar 18, 2026

The openshell-*.yaml pattern was listed twice in the stale manifest cleanup loop, causing redundant iteration over the same files.

Summary

Related Issue

Changes

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

@leoshi01 leoshi01 requested a review from a team as a code owner March 18, 2026 06:27
@github-actions
Copy link

github-actions bot commented Mar 18, 2026

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

The openshell-*.yaml pattern was listed twice in the stale manifest
cleanup loop, causing redundant iteration over the same files.
@leoshi01 leoshi01 force-pushed the fix/remove-duplicate-glob-pattern branch from 5c29a85 to d1b979a Compare March 18, 2026 06:43
@leoshi01
Copy link
Member Author

recheck

@leoshi01
Copy link
Member Author

I have read the DCO document and I hereby sign the DCO.

@leoshi01
Copy link
Member Author

Hi @drew ,
thanks for the approval! I don't have write access to this repo,
so the merge button isn't available to me. Could you either help merge this PR
or grant me write access? Happy either way. Thanks!

@drew drew merged commit 1d071b8 into NVIDIA:main Mar 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants