fix(sandbox): rotate openshell.log daily, keep 3 files#431
fix(sandbox): rotate openshell.log daily, keep 3 files#431Kh4L wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Replace unbounded append-only log with a RollingFileAppender (daily rotation, max 3 files). tracing-appender is already a workspace dependency so no new crates are needed. Closes NVIDIA#30 Signed-off-by: Serge Panev <spanev@nvidia.com>
|
Thank you for your interest in contributing to OpenShell, @Kh4L. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Reopening — you were incorrectly closed by the vouch gate. The workflow couldn't verify your NVIDIA org membership due to a GITHUB_TOKEN permissions issue. Fix is in #442. |
|
Thank you for your interest in contributing to OpenShell, @Kh4L. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Reopening now that #442 has merged. The vouch gate will now check author_association from the webhook payload, which correctly identifies you as an NVIDIA org member. |
|
Thank you for your interest in contributing to OpenShell, @Kh4L. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Reopening — the vouch gate now fetches author_association via the REST API (#444), which correctly identifies you as an NVIDIA org member. Sorry for the repeated closures! |
|
Thank you for your interest in contributing to OpenShell, @Kh4L. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
Summary
/var/log/openshell.logwith aRollingFileAppenderthat rotates daily and retains at most 3 filestracing-appenderis already a workspace dependency inopenshell-sandbox/var/logis not writable (existing behavior preserved)Related Issue
Closes #30
Changes
crates/openshell-sandbox/src/main.rs: replacestd::fs::OpenOptions+non_blocking(file)withRollingFileAppender::builder()configured for daily rotation and a 3-file capTesting
mise run testpasses/var/log/openshell.YYYY-MM-DD.loginside a running sandboxChecklist
git commit -s)