Conversation
drew
previously approved these changes
Mar 20, 2026
… chart
Disables GPU Feature Discovery and Node Feature Discovery DaemonSets and
overrides the device plugin's default nodeAffinity to null so it schedules
unconditionally on the single-node gateway without requiring NFD/GFD labels.
Setting affinity to an empty map ({}) does not override the chart defaults
because Helm deep-merges user values with chart defaults. Using null explicitly
removes the key, causing the chart template to skip the affinity block entirely.
elezar
force-pushed
the
feat/simplify-device-plugin-deployment
branch
from
677c6cb to
cca911f
Compare
pimlock
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodeAffinitytonullso the DaemonSet schedules unconditionally on the single-node gateway without requiring NFD/GFD labels (feature.node.kubernetes.io/pci-10de.present=trueornvidia.com/gpu.present=true)Related Issue
N/A — pure declarative simplification with no new runtime code paths.
Changes
deploy/kube/gpu-manifests/nvidia-device-plugin-helmchart.yaml: disablegfd/nfd, setaffinity: nulloverride, update comment blockarchitecture/gateway-single-node.md: update GPU Enablement section to explain NFD/GFD are disabled and why.agents/skills/debug-openshell-cluster/SKILL.md: add troubleshooting entry for lingering NFD/GFD DaemonSets on clusters deployed before this changeTesting
openshell gateway start --gpu— device plugin DaemonSet reaches Ready (1/1)kubectl get daemonset -A | grep -E 'nfd|gfd|node-feature'— no outputkubectl get node -o jsonpath='{.items[0].status.allocatable}'—nvidia.com/gpukey presentmise run test— no regressionsChecklist
mise run pre-commitpassed