Skip to content

fix(sandbox): emit warning when Landlock filesystem sandbox degrades silently #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johntmyers merged 2 commits into from
Mar 26, 2026
Merged

fix(sandbox): emit warning when Landlock filesystem sandbox degrades silently #599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
013d869
fix(sandbox): emit warning when Landlock filesystem sandbox degrades …
johntmyers Mar 24, 2026
3b69668
fix(sandbox): revert unintended ABI bump from V2 to V5
johntmyers Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions crates/openshell-sandbox/src/sandbox/linux/landlock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ use landlock::{
};
use miette::{IntoDiagnostic, Result};
use std::path::PathBuf;
use tracing::debug;
use tracing::{debug, info, warn};

pub fn apply(policy: &SandboxPolicy, workdir: Option<&str>) -> Result<()> {
let read_only = policy.filesystem.read_only.clone();
Expand All @@ -29,8 +29,16 @@ pub fn apply(policy: &SandboxPolicy, workdir: Option<&str>) -> Result<()> {
return Ok(());
}

let abi = ABI::V2;
info!(
abi = ?abi,
compatibility = ?policy.landlock.compatibility,
read_only_paths = read_only.len(),
read_write_paths = read_write.len(),
"Applying Landlock filesystem sandbox"
);

let result: Result<()> = (|| {
let abi = ABI::V2;
let access_all = AccessFs::from_all(abi);
let access_read = AccessFs::from_read(abi);

Expand Down Expand Up @@ -71,7 +79,11 @@ pub fn apply(policy: &SandboxPolicy, workdir: Option<&str>) -> Result<()> {
policy.landlock.compatibility,
LandlockCompatibility::BestEffort
) {
debug!(error = %err, "Landlock unavailable, continuing without filesystem sandbox");
warn!(
error = %err,
"Landlock filesystem sandbox is UNAVAILABLE — running WITHOUT filesystem restrictions. \
Set landlock.compatibility to 'hard_requirement' to make this a fatal error."
);
return Ok(());
}
return Err(err);
Expand Down
Loading