docs(agents): add security analysis protocol to principal-engineer-reviewer#711
Merged
johntmyers merged 2 commits intomainfrom Mar 31, 2026
Merged
docs(agents): add security analysis protocol to principal-engineer-reviewer#711johntmyers merged 2 commits intomainfrom
johntmyers merged 2 commits intomainfrom
Conversation
…viewer Add concrete security guidance including CWE/OWASP/CAPEC framework references, a threat modeling protocol for security-sensitive reviews, sandbox integrity checks, and a security checklist. Scoped to activate only when reviewing changes that touch security-sensitive areas.
…ition Mirror the same security enhancements from the claude agent definition to the opencode principal-engineer-reviewer agent.
pimlock
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds concrete security analysis guidance to the principal-engineer-reviewer agent, including framework references (CWE, OWASP ASVS, OWASP Top 10 for LLM, CAPEC), a prescriptive threat modeling protocol, and a security checklist. The new guidance activates contextually for security-sensitive reviews only.
Changes
Testing
mise run pre-commitpassesChecklist