feat(ci): add driver input to setup-buildx action#941
Merged
Conversation
Signed-off-by: Jonas Toelke <jtoelke@nvidia.com>
pimlock
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
driverinput to.github/actions/setup-buildx/action.yml. Default staysremote, preserving current behavior for all 7 call sites. Newlocaloption selects thedocker-containerdriver for callers that need buildx on nv-gha-runners (no EKS BuildKit). Pure-additive prep for the OS-127 Phase 3 shadow workflow.Related Issue
OS-49 runner migration, Phase 3 / OS-127. This is PR 2 (prep). PR 3 (shadow workflow using
driver: local+ GHA cache) follows once this lands.Changes
.github/actions/setup-buildx/action.yml:driverinput withdefault: remote.if: inputs.driver == 'remote'— unchanged wiring to the in-cluster BuildKit endpoints (tcp://buildkit-{amd64,arm64}.buildkit:1234).if: inputs.driver == 'local'— new,docker/setup-buildx-action@v3withdriver: docker-container, no endpoints.amd64-endpoint,arm64-endpoint,name) unchanged; description clarified as remote-only.No caller updated. Default resolution keeps all 7 existing callers (
ci-image.yml,docker-build.yml,release-tag.yml×3,release-vm-dev.yml×2,release-dev.yml×2) on the remote path.Testing
mise run pre-commitpassesChecklist
create_documentis currently returningTool not found— will attach the plan doc once it recovers or fall back to a Linear comment)