Skip to content

feat(ci): add driver input to setup-buildx action#941

Merged
jtoelke2 merged 1 commit intomainfrom
jtoelke/os-127-setup-buildx-driver-input
Apr 24, 2026
Merged

feat(ci): add driver input to setup-buildx action#941
jtoelke2 merged 1 commit intomainfrom
jtoelke/os-127-setup-buildx-driver-input

Conversation

@jtoelke2
Copy link
Copy Markdown
Collaborator

Summary

Add a driver input to .github/actions/setup-buildx/action.yml. Default stays remote, preserving current behavior for all 7 call sites. New local option selects the docker-container driver for callers that need buildx on nv-gha-runners (no EKS BuildKit). Pure-additive prep for the OS-127 Phase 3 shadow workflow.

Related Issue

OS-49 runner migration, Phase 3 / OS-127. This is PR 2 (prep). PR 3 (shadow workflow using driver: local + GHA cache) follows once this lands.

Changes

  • .github/actions/setup-buildx/action.yml:
    • New driver input with default: remote.
    • Setup step split into two conditional steps:
      • if: inputs.driver == 'remote' — unchanged wiring to the in-cluster BuildKit endpoints (tcp://buildkit-{amd64,arm64}.buildkit:1234).
      • if: inputs.driver == 'local' — new, docker/setup-buildx-action@v3 with driver: docker-container, no endpoints.
    • Existing inputs (amd64-endpoint, arm64-endpoint, name) unchanged; description clarified as remote-only.

No caller updated. Default resolution keeps all 7 existing callers (ci-image.yml, docker-build.yml, release-tag.yml ×3, release-vm-dev.yml ×2, release-dev.yml ×2) on the remote path.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated — N/A; composite GitHub Action
  • E2E tests added/updated — N/A
  • Remote-driver path exercised by every Rust/Docker CI job on this PR (7 call sites)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated — N/A; plan lives in Linear OS-127 (doc pending; MCP create_document is currently returning Tool not found — will attach the plan doc once it recovers or fall back to a Linear comment)

Signed-off-by: Jonas Toelke <jtoelke@nvidia.com>
@jtoelke2 jtoelke2 requested a review from a team as a code owner April 23, 2026 18:01
@jtoelke2 jtoelke2 self-assigned this Apr 23, 2026
@jtoelke2 jtoelke2 requested a review from pimlock April 23, 2026 21:06
@jtoelke2 jtoelke2 merged commit a4dfa5a into main Apr 24, 2026
17 checks passed
@jtoelke2 jtoelke2 deleted the jtoelke/os-127-setup-buildx-driver-input branch April 24, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants