Skip to content

fix(ci): ignore local artifacts in license checks#974

Merged
johntmyers merged 1 commit intomainfrom
fix/license-ignore-local-plans
Apr 24, 2026
Merged

fix(ci): ignore local artifacts in license checks#974
johntmyers merged 1 commit intomainfrom
fix/license-ignore-local-plans

Conversation

@johntmyers
Copy link
Copy Markdown
Collaborator

Summary

Make the license-header check use Git tracked/unignored file discovery so ignored local agent artifacts under architecture/plans/ do not fail CI or pre-commit. Also fixes the malformed .claude/settings.local.json ignore entry and stabilizes the Podman Unix-socket test stub that blocked full pre-commit verification.

Related Issue

None.

Changes

  • Discover license-header candidates from git ls-files --cached --others --exclude-standard by default.
  • Skip explicitly provided paths when Git ignore rules exclude them.
  • Fix the .claude/settings.local.json ignore rule.
  • Allow Podman test stubs to tolerate Hyper shutdown after one-shot client responses.
  • Normalize the stale Cargo.lock rand dependency edge updated by Cargo during verification.

Testing

  • mise run pre-commit passes
  • mise exec -- cargo test -p openshell-driver-podman --lib passes
  • uv run ruff check scripts/update_license_headers.py passes
  • uv run ruff format --check scripts/update_license_headers.py passes
  • mise run license:check passes
  • Explicit ignored plan-file check returns Checking 0 files for SPDX headers...

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (not applicable)

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
@johntmyers johntmyers requested a review from a team as a code owner April 24, 2026 21:51
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 24, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@johntmyers johntmyers merged commit bb5bdb4 into main Apr 24, 2026
11 checks passed
@johntmyers johntmyers deleted the fix/license-ignore-local-plans branch April 24, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants