This repository was archived by the owner on Dec 11, 2025. It is now read-only.
Remove MAX_SWAPCHAIN_IMAGES limit for XWayland#122
Merged
apanteleev merged 1 commit intoNVIDIA:masterfrom Jun 9, 2021
Merged
Conversation
A well-behaved Vulkan application should not care about the number of swapchain images exposed by vkGetSwapchainImagesKHR. In XWayland (right now), there is no IMMEDIATE mode, only MAILBOX, which is exposed as IMMEDIATE. However, this means that the max number of swapchain images exceeds what would normally be expected for typical IMMEDIATE implementations under X11. With this change I can run Quake 2 RTX under XWayland on my Radeon VII. This will also likely be needed by NVIDIA following the release of their 470 driver which enables [X]Wayland support. Signed-off-by: Joshua Ashton <joshua@froggi.es>
|
Hello All! This game is only XWayland right now, or can be run with pure Wayland? |
Contributor
Author
|
It works on native wl |
|
Anything extra is needed for the Wayland mode? For me it looks XWayland is used by default on my Manjaro/Gnome rig. |
Contributor
Author
|
SDL_VIDEODRIVER=wayland |
|
Thanks, but somehow it just generates an error message:
[image: image.png]
…On Sun, 20 Mar 2022 at 19:07, Joshie ***@***.***> wrote:
SDL_VIDEODRIVER=wayland
—
Reply to this email directly, view it on GitHub
<#122 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEH2G2W7LY7DQRDQBWEE2J3VA5SLNANCNFSM46LHI3CA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
|
Contributor
Author
|
There is no image |
|
Sorry, the image is here: |
Contributor
|
Okay, the issue is a combination of (a) Q2RTX on Linux shipping it's own copy of SDL and (b) that copy not being built with Wayland support. (See eg here: https://github.com/NVIDIA/Q2RTX/runs/5505535453?check_suite_focus=true, the build-linux-x64/Configure output.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A well-behaved Vulkan application should not care about the number of swapchain images exposed by vkGetSwapchainImagesKHR.
In XWayland (right now), there is no IMMEDIATE mode, only MAILBOX, which is exposed as IMMEDIATE.
However, this means that the max number of swapchain images exceeds what would normally be expected for typical IMMEDIATE implementations under X11.
With this change I can run Quake 2 RTX under XWayland on my Radeon VII.
This will also likely be needed by NVIDIA following the release of their 470 driver which enables [X]Wayland support.
Signed-off-by: Joshua Ashton joshua@froggi.es