fix(yara): reduce packaged malware-signature false positives (#236)#247
Open
rodboev wants to merge 1 commit into
Open
fix(yara): reduce packaged malware-signature false positives (#236)#247rodboev wants to merge 1 commit into
rodboev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillSpector should avoid shipping raw malware-signature rule source in a form that causes repository archives to look like malware payloads, while preserving the built-in YARA detector behavior those rules provide.
Closes #236
Root cause
The YARA analyzer compiles built-in rule files directly from
src/skillspector/yara_rules, includingmalware.yar. Those rule strings are benign detector material, but archive scanners can treat them as suspicious content when scanning the repository zip itself.Diff Notes
malware.yarpackage file with an encoded built-in asset thatstatic_yaradecodes at load time, so the detector source no longer ships as plain rule text.YR1severity/category behavior.Scope
This does not remove malware detection, disable YARA, rename
--yara-rules-dir, or claim that external scanners are clean unless that live scanner proof is collected.Verification
.\.venv\Scripts\python.exe -m pytest tests/nodes/analyzers/test_static_yara.py.\.venv\Scripts\python.exe -m pytest tests/nodes/analyzers/test_static_yara.py -k "malformed or build_namespace or builtin or extra".\.venv\Scripts\python.exe -m pytest tests/nodes/analyzers/test_static_yara.py -k "collect_rule_files_finds_yar"rg -n "bash -i >& /dev/tcp/127\.0\.0\.1/4444 0>&1" src testsreturns no matchesuv run ruff check src/ tests/uv run ruff format --check src/ tests/