[None] [fix] Fix slrum scripts

[kaiyux]

Summary by CodeRabbit

Release Notes

• New Features

  • Added support for benchmark mode configuration through command-line arguments.

• Bug Fixes

  • Improved configuration robustness by introducing default values for parallel size parameters, preventing errors when optional keys are missing.

• Chores

  • Refined context server URL collection mechanism.
  • Optimized command-line argument parsing structure.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[coderabbitai]

📝 Walkthrough

Walkthrough

These changes add benchmark mode support to the disaggregated SLURM benchmark infrastructure by introducing a new --benchmark-mode argument, updating how context server URLs are constructed from a pre-collected list, and propagating benchmark configuration through worker commands and batch submission.

Changes

Cohort / File(s)	Summary
Benchmark mode argument support examples/disaggregated/slurm/benchmark/disaggr_torch.slurm, examples/disaggregated/slurm/benchmark/submit.py	Added --benchmark-mode command-line argument to argument parser and echoed its value; propagated benchmark mode from config to worker launch and batch submission commands.
Context server URL construction examples/disaggregated/slurm/benchmark/gen_server_config.py	Changed context server URL construction to use pre-collected ctx_urls list instead of deriving URLs from hostnames and port.
Configuration robustness examples/disaggregated/slurm/benchmark/submit.py	Updated tensor/context/pipeline parallel size retrieval to use .get(..., 1) with default values; moved log-dir argument registration from group parser to main parser.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify that ctx_urls is properly populated before use in gen_server_config.py
• Confirm benchmark mode is correctly threaded through all command construction points in submit.py
• Ensure default parallel size values of 1 are semantically correct for existing configurations and don't introduce unexpected behavior when keys are missing

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check	⚠️ Warning	The PR description is incomplete. While the template structure is present, all required sections are empty: the title lacks a proper ticket reference, the Description section is blank, and Test Coverage is not documented.	Complete the PR description by: (1) providing a clear, descriptive title with proper ticket format; (2) explaining what the changes do and why they are needed; (3) documenting relevant test cases that validate the changes.
Title check	❓ Inconclusive	The title contains a typo ('slrum' instead of 'slurm') and is vague about what specifically was fixed, lacking concrete details about the changes.	Correct the typo and provide a more specific title describing the actual fixes, e.g., '[None][fix] Add benchmark mode argument and fix context server URL handling in SLURM scripts'.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[kaiyux]

/bot skip --comment "slurm scripts are not protected by CI pipeline yet"

[tensorrt-cicd]

PR_Github #28384 [ skip ] triggered by Bot. Commit: b864848

[kaiyux]

/bot skip --comment "slurm scripts are not protected by CI pipeline yet"

[tensorrt-cicd]

PR_Github #28385 [ skip ] triggered by Bot. Commit: 754c2eb

[tensorrt-cicd]

PR_Github #28384 [ skip ] completed with state ABORTED. Commit: b864848

[tensorrt-cicd]

PR_Github #28385 [ skip ] completed with state SUCCESS. Commit: 754c2eb
Skipping testing for commit 754c2eb