Skip to content

Conversation

@yuxianq
Copy link
Collaborator

@yuxianq yuxianq commented Jan 6, 2026

Summary by CodeRabbit

  • Tests
    • Updated test identifier in the DGX H200 integration test suite to include isolation flag for enhanced test categorization and execution management.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: Yuxian Qiu <142763828+yuxianq@users.noreply.github.com>
@yuxianq yuxianq requested a review from EmmaQiaoCh January 6, 2026 08:40
@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 6, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

A test identifier in the l0_dgx_h200.yml integration test list was appended with " ISOLATION" suffix to designate isolation mode for a specific test case, without modifying test logic or structure.

Changes

Cohort / File(s) Summary
Test Configuration Label Update
tests/integration/test_lists/test-db/l0_dgx_h200.yml
Test identifier for test_bfloat16_4gpus[ep4-mtp_nextn=0-attention_dp=False-cuda_graph=False-overlap_scheduler=False-torch_compile=False] appended with " ISOLATION" suffix for test annotation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description consists entirely of the repository's template with placeholder comments and uncompleted sections; no actual description, test coverage information, or explanation of the change is provided. Fill in the Description section explaining why the test needs isolation, and complete the Test Coverage section listing which tests are affected by this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title correctly follows the required format with [NVBugs ID][type] structure and accurately describes the change as a chore to isolate a test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df0b976 and 6e64af7.

📒 Files selected for processing (1)
  • tests/integration/test_lists/test-db/l0_dgx_h200.yml
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7497
File: tests/integration/defs/test_list_parser.py:0-0
Timestamp: 2025-09-09T13:33:32.247Z
Learning: The ISOLATE marker in test_list_parser.py is used for test list parsing and Jenkins pipeline logic, not for creating pytest markers. It allows the parser to recognize ISOLATE markers in test list files, which the Jenkins pipeline then uses to separate tests that need isolation, but no pytest.mark.isolate marker is created.
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.
📚 Learning: 2025-09-09T09:40:45.658Z
Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

  • tests/integration/test_lists/test-db/l0_dgx_h200.yml
📚 Learning: 2025-09-17T02:48:52.732Z
Learnt from: tongyuantongyu
Repo: NVIDIA/TensorRT-LLM PR: 7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

  • tests/integration/test_lists/test-db/l0_dgx_h200.yml
📚 Learning: 2025-09-09T13:33:32.247Z
Learnt from: EmmaQiaoCh
Repo: NVIDIA/TensorRT-LLM PR: 7497
File: tests/integration/defs/test_list_parser.py:0-0
Timestamp: 2025-09-09T13:33:32.247Z
Learning: The ISOLATE marker in test_list_parser.py is used for test list parsing and Jenkins pipeline logic, not for creating pytest markers. It allows the parser to recognize ISOLATE markers in test list files, which the Jenkins pipeline then uses to separate tests that need isolation, but no pytest.mark.isolate marker is created.

Applied to files:

  • tests/integration/test_lists/test-db/l0_dgx_h200.yml
📚 Learning: 2025-07-28T17:06:08.621Z
Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

  • tests/integration/test_lists/test-db/l0_dgx_h200.yml
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
Repo: NVIDIA/TensorRT-LLM PR: 7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

  • tests/integration/test_lists/test-db/l0_dgx_h200.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/test-db/l0_dgx_h200.yml (1)

92-92: No action required; the change is correct.

The ISOLATION marker is already used consistently across other test list files (l0_a10.yml, l0_a100.yml, l0_b200.yml) and follows the established pattern. These markers are intended for external tooling like the Jenkins pipeline, not for the Python test list parser itself. The parser only recognizes XFAIL, SKIP, UNSTABLE, and TIMEOUT markers for pytest-level processing, while ISOLATION markers are handled separately by the CI/CD pipeline for test isolation logic.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30712 [ run ] triggered by Bot. Commit: 6e64af7

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30712 [ run ] completed with state SUCCESS. Commit: 6e64af7
/LLM/main/L0_MergeRequest_PR pipeline #23698 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 7, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30819 [ run ] triggered by Bot. Commit: 3d3f9c4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30819 [ run ] completed with state SUCCESS. Commit: 3d3f9c4
/LLM/main/L0_MergeRequest_PR pipeline #23799 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 7, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30880 [ run ] triggered by Bot. Commit: 3d3f9c4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30880 [ run ] completed with state SUCCESS. Commit: 3d3f9c4
/LLM/main/L0_MergeRequest_PR pipeline #23845 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 8, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30998 [ run ] triggered by Bot. Commit: 2d0f364

@tensorrt-cicd
Copy link
Collaborator

PR_Github #30998 [ run ] completed with state SUCCESS. Commit: 2d0f364
/LLM/main/L0_MergeRequest_PR pipeline #23950 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 9, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31177 [ run ] triggered by Bot. Commit: f546bd0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31177 [ run ] completed with state SUCCESS. Commit: f546bd0
/LLM/main/L0_MergeRequest_PR pipeline #24091 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 10, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31302 [ run ] triggered by Bot. Commit: f546bd0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31302 [ run ] completed with state SUCCESS. Commit: f546bd0
/LLM/main/L0_MergeRequest_PR pipeline #24196 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 11, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31401 [ run ] triggered by Bot. Commit: f546bd0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31401 [ run ] completed with state DISABLED
CI server is currently disabled for scheduled maintenance. Estimated completion time: 8 AM PST on 1/11.

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 12, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31452 [ run ] triggered by Bot. Commit: f546bd0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31452 [ run ] completed with state SUCCESS. Commit: f546bd0
/LLM/main/L0_MergeRequest_PR pipeline #24313 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 12, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31494 [ run ] triggered by Bot. Commit: f546bd0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31494 [ run ] completed with state FAILURE. Commit: f546bd0
/LLM/main/L0_MergeRequest_PR pipeline #24346 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 12, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31542 [ run ] triggered by Bot. Commit: f546bd0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31542 [ run ] completed with state SUCCESS. Commit: f546bd0
/LLM/main/L0_MergeRequest_PR pipeline #24387 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 13, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31652 [ run ] triggered by Bot. Commit: f546bd0

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31652 [ run ] completed with state SUCCESS. Commit: f546bd0
/LLM/main/L0_MergeRequest_PR pipeline #24482 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 13, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31681 [ run ] triggered by Bot. Commit: 12db3c2

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31681 [ run ] completed with state SUCCESS. Commit: 12db3c2
/LLM/main/L0_MergeRequest_PR pipeline #24509 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 14, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31866 [ run ] triggered by Bot. Commit: e3a7c0d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #31866 [ run ] completed with state SUCCESS. Commit: e3a7c0d
/LLM/main/L0_MergeRequest_PR pipeline #24677 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yuxianq
Copy link
Collaborator Author

yuxianq commented Jan 15, 2026

/bot run --disable-fail-fast --extra-stage "DGX_H200-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32097 [ run ] triggered by Bot. Commit: e3a7c0d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32097 [ run ] completed with state SUCCESS. Commit: e3a7c0d
/LLM/main/L0_MergeRequest_PR pipeline #24878 completed with status: 'SUCCESS'

@yuxianq yuxianq merged commit ef838cc into NVIDIA:main Jan 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants