[TRTLLM-10415][feat] Dump thread stacks for hanging tests before time… #10708
Conversation
|
/bot run |
📝 WalkthroughWalkthroughA signal handler for SIGALRM is registered in pytest configuration to enable on-demand thread stack dumps during test execution. A new utility function captures and prints the call stacks of all non-current threads for debugging purposes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@tests/unittest/conftest.py`:
- Around line 57-58: signal.SIGALRM is Unix-only and will raise AttributeError
on Windows; wrap the registration call so it only runs when SIGALRM exists
(e.g., check hasattr(signal, "SIGALRM") or use sys.platform/os.name) and call
signal.signal(signal.SIGALRM, dump_threads) only when present, leaving
dump_threads unchanged.
- Around line 42-51: The dump_threads function uses the private
threading._active and can raise a KeyError if a thread dies between lookup and
accessing sys._current_frames(); change iteration to use the public
threading.enumerate() and for each thread use thread.ident to look up the stack
in sys._current_frames() safely (use sys._current_frames().get(thread_id) and
skip if None), keep skipping the current_thread via threading.current_thread(),
and wrap the stack retrieval/printing in a small try/except to avoid propagating
errors if a thread disappears; retain the signum/frame parameters for the signal
handler signature.
🧹 Nitpick comments (1)
tests/unittest/conftest.py (1)
1-1: Update copyright year.As per coding guidelines, the copyright header should reflect the year of the latest meaningful modification. Since this PR adds new functionality in 2026, consider updating the year range.
-# SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/unittest/conftest.py
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: The code developed for TensorRT-LLM should conform to Python 3.8+
Indent Python code with 4 spaces. Do not use tabs
Always maintain the namespace when importing Python modules, even if only one class or function from a module is used
Python filenames should use snake_case (e.g.,some_file.py)
Python classes should use PascalCase (e.g.,class SomeClass)
Python functions and methods should use snake_case (e.g.,def my_awesome_function():)
Python local variables should use snake_case, with prefixkfor variable names that start with a number (e.g.,k_99th_percentile)
Python global variables should use upper snake_case with prefixG(e.g.,G_MY_GLOBAL)
Python constants should use upper snake_case (e.g.,MY_CONSTANT)
Avoid shadowing variables declared in an outer scope in Python
Initialize all externally visible members of a Python class in the constructor
For Python interfaces that may be used outside a file, prefer docstrings over comments
Use comments in Python for code within a function, or interfaces that are local to a file
Use Google-style docstrings for Python classes and functions, which can be parsed by Sphinx
Python attributes and variables can be documented inline with the format"""<type>: Description"""
Avoid using reflection in Python when functionality can be easily achieved without reflection
When using try-except blocks in Python, limit the except clause to the smallest set of errors possible
When using try-except blocks in Python to handle multiple possible variable types (duck-typing), keep the body of the try as small as possible and use the else block for the main logic
Files:
tests/unittest/conftest.py
**/*.{cpp,cc,cxx,h,hpp,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
All TensorRT-LLM source files (.cpp, .h, .cu, .py, and other source files) should contain an NVIDIA copyright header with the year of latest meaningful modification
Files:
tests/unittest/conftest.py
🧬 Code graph analysis (1)
tests/unittest/conftest.py (1)
tests/integration/defs/conftest.py (1)
pytest_configure(2363-2412)
🪛 Ruff (0.14.11)
tests/unittest/conftest.py
42-42: Unused function argument: signum
(ARG001)
42-42: Unused function argument: frame
(ARG001)
53-53: Unused function argument: config
(ARG001)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/unittest/conftest.py (1)
17-19: LGTM!The new imports for
signalandthreadingare correctly placed and follow the coding guidelines for maintaining namespaces.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
|
PR_Github #32124 [ run ] triggered by Bot. Commit: |
|
PR_Github #32124 [ run ] completed with state |
|
/bot run |
|
PR_Github #32590 [ run ] triggered by Bot. Commit: |
|
PR_Github #32590 [ run ] completed with state
|
WeiHaocheng
force-pushed
the
feat/main_ci_timeout_dump_traceback
branch
from
999d7d0 to
cb1fda8
Compare
|
/bot run |
|
PR_Github #32625 [ run ] triggered by Bot. Commit: |
|
PR_Github #32625 [ run ] completed with state
|
WeiHaocheng
force-pushed
the
feat/main_ci_timeout_dump_traceback
branch
from
cb1fda8 to
4564a3b
Compare
|
/bot reuse-pipeline |
|
PR_Github #32936 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #32936 [ reuse-pipeline ] completed with state |
…out termination in CI Signed-off-by: Fred Wei <20514172+WeiHaocheng@users.noreply.github.com>
WeiHaocheng
force-pushed
the
feat/main_ci_timeout_dump_traceback
branch
from
4564a3b to
6de7c79
Compare
|
/bot run |
|
PR_Github #33875 [ run ] triggered by Bot. Commit: |
|
PR_Github #33875 [ run ] completed with state
|
|
/bot run |
|
PR_Github #34038 [ run ] triggered by Bot. Commit: |
|
PR_Github #34038 [ run ] completed with state |
5 participants
…out termination in CI
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.