Skip to content

Conversation

@hyukn
Copy link
Collaborator

@hyukn hyukn commented Jan 19, 2026

Summary by CodeRabbit

  • Tests
    • Re-enabled testing for the distributed autotuner strategy variant that was previously skipped.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

…tegy tests

Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
@hyukn
Copy link
Collaborator Author

hyukn commented Jan 19, 2026

/bot run --disable-fail-fast

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 19, 2026

📝 Walkthrough

Walkthrough

A SKIP annotation for a single parametrized test was removed from the test waiver list, allowing the previously skipped distributed strategy autotuner test to execute during test runs.

Changes

Cohort / File(s) Summary
Test Waiver Removal
tests/integration/test_lists/waives.txt
Removed SKIP annotation for test_autotuner_distributed_strategy[2-DistributedTuningStrategy.BROADCAST] (1 line removed)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty. Only the template headers and boilerplate content are present with no actual details provided. Add a substantive description explaining why the test was being skipped and why it is now safe to unskip it. Include details on how the underlying issue (nvbugs/5814253) was resolved.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title follows the required template format with NVBugs ID and [fix] type, clearly summarizing the main change of removing a test skip annotation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32510 [ run ] triggered by Bot. Commit: d94343d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32510 [ run ] completed with state SUCCESS. Commit: d94343d
/LLM/main/L0_MergeRequest_PR pipeline #25178 completed with status: 'SUCCESS'

@hyukn
Copy link
Collaborator Author

hyukn commented Jan 19, 2026

/bot run ---add-multi-gpu-test ---disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32546 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: ---add-multi-gpu-test ---disable-fail-fast

@hyukn
Copy link
Collaborator Author

hyukn commented Jan 19, 2026

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32551 [ run ] triggered by Bot. Commit: d94343d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32551 [ run ] completed with state SUCCESS. Commit: d94343d
/LLM/main/L0_MergeRequest_PR pipeline #25201 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Signed-off-by: Yukun He <23156053+hyukn@users.noreply.github.com>
@hyukn hyukn requested a review from a team as a code owner January 20, 2026 02:26
@hyukn hyukn requested a review from yizhang-nv January 20, 2026 02:26
@hyukn
Copy link
Collaborator Author

hyukn commented Jan 20, 2026

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32634 [ run ] triggered by Bot. Commit: c7034ee

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32634 [ run ] completed with state SUCCESS. Commit: c7034ee
/LLM/main/L0_MergeRequest_PR pipeline #25265 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@hyukn
Copy link
Collaborator Author

hyukn commented Jan 20, 2026

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32717 [ run ] triggered by Bot. Commit: c7034ee

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32717 [ run ] completed with state SUCCESS. Commit: c7034ee
/LLM/main/L0_MergeRequest_PR pipeline #25322 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@hyukn
Copy link
Collaborator Author

hyukn commented Jan 21, 2026

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32829 [ run ] triggered by Bot. Commit: c7034ee

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32829 [ run ] completed with state SUCCESS. Commit: c7034ee
/LLM/main/L0_MergeRequest_PR pipeline #25402 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@hyukn
Copy link
Collaborator Author

hyukn commented Jan 21, 2026

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32863 [ run ] triggered by Bot. Commit: c7034ee

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32863 [ run ] completed with state SUCCESS. Commit: c7034ee
/LLM/main/L0_MergeRequest_PR pipeline #25423 completed with status: 'SUCCESS'

@hyukn hyukn merged commit a4152c8 into NVIDIA:main Jan 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants