Skip to content

Conversation

@pengbowang-nv
Copy link
Collaborator

@pengbowang-nv pengbowang-nv commented Jan 20, 2026

Summary by CodeRabbit

  • Tests
    • Re-enabled two previously skipped tests for Llama3.3 70B Instruct model, expanding test coverage for specific configurations.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

The waive is due to be an issue in the accuracy issue in two-shot kernels that have recently been exposed by AutoTuning. The fixing PR #10654 on release/1.2 has been merged. Tested locally the fix worked. This PR unwaives related test.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@pengbowang-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32790 [ run ] triggered by Bot. Commit: b571c12

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32790 [ run ] completed with state SUCCESS. Commit: b571c12
/LLM/release-1.2/L0_MergeRequest_PR pipeline #85 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@pengbowang-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32840 [ run ] triggered by Bot. Commit: b571c12

@pengbowang-nv
Copy link
Collaborator Author

/bot kill

Signed-off-by: Pengbo Wang <221450789+pengbowang-nv@users.noreply.github.com>
@pengbowang-nv pengbowang-nv force-pushed the fix-unwaive-llama-3-3-tests branch from b571c12 to 69d8e29 Compare January 21, 2026 06:00
@pengbowang-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32875 [ kill ] triggered by Bot. Commit: 69d8e29

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32875 [ kill ] completed with state SUCCESS. Commit: 69d8e29
Successfully killed previous jobs for commit 69d8e29

@pengbowang-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32876 [ run ] triggered by Bot. Commit: 69d8e29

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32878 [ run ] triggered by Bot. Commit: 69d8e29

@pengbowang-nv pengbowang-nv marked this pull request as ready for review January 21, 2026 07:59
@pengbowang-nv pengbowang-nv requested a review from a team as a code owner January 21, 2026 07:59
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

Two SKIP markers are removed from the test waives list, causing their corresponding test cases to no longer be globally skipped and resume execution in the test suite.

Changes

Cohort / File(s) Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt
Removed 2 SKIP markers for: accuracy/test_llm_api_pytorch.py::TestLlama3_3_70BInstruct::test_nvfp4_tp4[torch_compile=False] and accuracy/test_llm_api_pytorch.py::TestLlama3_3_70BInstruct::test_fp8_tp4[torch_compile=False]. These tests are no longer globally skipped.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: removing skip markers from the waives.txt file to re-enable Llama 3.3 multi-GPU tests that were previously waived due to an accuracy fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed PR description explains the issue (accuracy in two-shot kernels) and the solution (unwaiving tests after fix merge), but lacks detail in Test Coverage section.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pengbowang-nv pengbowang-nv enabled auto-merge (squash) January 21, 2026 08:01
@tensorrt-cicd
Copy link
Collaborator

PR_Github #32878 [ run ] completed with state SUCCESS. Commit: 69d8e29
/LLM/release-1.2/L0_MergeRequest_PR pipeline #105 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@pengbowang-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32969 [ run ] triggered by Bot. Commit: 69d8e29

@pengbowang-nv
Copy link
Collaborator Author

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32990 [ run ] triggered by Bot. Commit: 69d8e29

@tensorrt-cicd
Copy link
Collaborator

PR_Github #32990 [ run ] completed with state SUCCESS. Commit: 69d8e29
/LLM/release-1.2/L0_MergeRequest_PR pipeline #133 completed with status: 'SUCCESS'

@pengbowang-nv pengbowang-nv merged commit 8cc475c into NVIDIA:release/1.2 Jan 22, 2026
10 of 13 checks passed
@pengbowang-nv pengbowang-nv deleted the fix-unwaive-llama-3-3-tests branch January 23, 2026 02:57
pengbowang-nv added a commit to pengbowang-nv/TensorRT-LLM that referenced this pull request Jan 23, 2026
…ts (NVIDIA#10855)

Signed-off-by: Pengbo Wang <221450789+pengbowang-nv@users.noreply.github.com>
pengbowang-nv added a commit to pengbowang-nv/TensorRT-LLM that referenced this pull request Jan 23, 2026
…ts (NVIDIA#10855)

Signed-off-by: Pengbo Wang <221450789+pengbowang-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants