Skip to content

[TRTLLM-9970][infra] Get TOT waive list from github repo first and then gitlab repo#11063

Merged
yiqingy0 merged 9 commits intoNVIDIA:mainfrom
yiqingy0:fix_tot_repo
Apr 2, 2026
Merged

[TRTLLM-9970][infra] Get TOT waive list from github repo first and then gitlab repo#11063
yiqingy0 merged 9 commits intoNVIDIA:mainfrom
yiqingy0:fix_tot_repo

Conversation

@yiqingy0
Copy link
Copy Markdown
Collaborator

@yiqingy0 yiqingy0 commented Jan 28, 2026

Summary by CodeRabbit

  • Infrastructure Improvements
    • Enhanced merge process reliability with improved error handling and fallback mechanisms
    • Better status reporting when critical data retrieval encounters issues

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@yiqingy0
Copy link
Copy Markdown
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #33948 [ run ] triggered by Bot. Commit: 78ed238

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #33948 [ run ] completed with state FAILURE. Commit: 78ed238
/LLM/main/L0_MergeRequest_PR pipeline #26185 (Partly Tested) completed with status: 'ABORTED'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yiqingy0
Copy link
Copy Markdown
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #33957 [ run ] triggered by Bot. Commit: 0439198

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #33957 [ run ] completed with state FAILURE. Commit: 0439198
/LLM/main/L0_MergeRequest_PR pipeline #26193 (Partly Tested) completed with status: 'ABORTED'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@yiqingy0 yiqingy0 marked this pull request as ready for review January 29, 2026 07:09
@yiqingy0 yiqingy0 requested review from a team as code owners January 29, 2026 07:09
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 29, 2026

📝 Walkthrough

Walkthrough

Adds a resilient TOT waive list retrieval mechanism to mergeWaiveList with two-stage checkout attempts: first from a remote repository, then falling back to the default GitLab-hosted LLM repository. Includes error handling to report unstable state and exit early if TOT data cannot be obtained from either source.

Changes

Cohort / File(s) Summary
TOT Waive List Retrieval Enhancement
jenkins/L0_MergeRequest.groovy
Implements robust fallback logic for obtaining TOT waive lists with error handling for remote repository checkout failure and graceful degradation to GitLab-hosted repository, including unstable status reporting when both sources are unavailable.

Sequence Diagram(s)

sequenceDiagram
    participant Script as L0_MergeRequest.groovy
    participant RemoteRepo as Remote TOT Repository
    participant GitLabRepo as GitLab LLM Repository
    participant Status as Build Status/Report

    Script->>RemoteRepo: Attempt checkout TOT waive list
    alt Remote checkout succeeds
        RemoteRepo-->>Script: TOT waive list obtained
    else Remote checkout fails
        Script->>GitLabRepo: Fallback: checkout default LLM waive list
        alt GitLab checkout succeeds
            GitLabRepo-->>Script: Default waive list obtained
        else GitLab checkout fails
            Script->>Status: Report unstable state
            Status-->>Script: Unstable status recorded
            Script-->>Script: Return early, skip merge
        end
    end
    Script->>Script: Proceed with waiver-diff merge using obtained TOT commit
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description consists entirely of the repository template with no actual implementation details, rationale, or test coverage information provided. Add a substantive description explaining the problem being solved, the solution approach, which tests cover the changes, and review the PR checklist items for completeness.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly describes the main infrastructure change: retrieving a TOT waive list from GitHub repository first, then falling back to GitLab, which aligns with the code changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@yiqingy0
Copy link
Copy Markdown
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #36885 [ run ] triggered by Bot. Commit: 923b7bb Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #36885 [ run ] completed with state FAILURE. Commit: 923b7bb
/LLM/main/L0_MergeRequest_PR pipeline #28559 (Partly Tested) completed with status: 'ABORTED'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@yiqingy0
Copy link
Copy Markdown
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #36902 [ run ] triggered by Bot. Commit: 1d5c8ee Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #36902 [ run ] completed with state SUCCESS. Commit: 1d5c8ee
/LLM/main/L0_MergeRequest_PR pipeline #28571 (Partly Tested) completed with status: 'SUCCESS'

Link to invocation

@yiqingy0
Copy link
Copy Markdown
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39434 [ run ] triggered by Bot. Commit: 1928c3f Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39434 [ run ] completed with state SUCCESS. Commit: 1928c3f
/LLM/main/L0_MergeRequest_PR pipeline #30662 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

yiqingy0 and others added 7 commits March 31, 2026 23:55
Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
@yiqingy0
Copy link
Copy Markdown
Collaborator Author

yiqingy0 commented Apr 1, 2026

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41152 [ run ] triggered by Bot. Commit: c655195 Link to invocation

Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
@yiqingy0
Copy link
Copy Markdown
Collaborator Author

yiqingy0 commented Apr 1, 2026

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41170 [ run ] triggered by Bot. Commit: 1fec95f Link to invocation

Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
@yiqingy0
Copy link
Copy Markdown
Collaborator Author

yiqingy0 commented Apr 1, 2026

/bot run --skip-test

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41171 [ run ] triggered by Bot. Commit: 40c8d06 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41170 [ run ] completed with state ABORTED. Commit: 1fec95f
LLM/dev_yiqingy/L0_MergeRequest_PR #35 (Blue Ocean) completed with status: ABORTED

Link to invocation

@yiqingy0 yiqingy0 changed the title [TRTLLM-9970][infra] Get TOT waive list from github repo or gitlab repo [TRTLLM-9970][infra] Get TOT waive list from github repo first and then gitlab repo Apr 1, 2026
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41171 [ run ] completed with state ABORTED. Commit: 40c8d06
LLM/dev_yiqingy/L0_MergeRequest_PR #36 (Blue Ocean) completed with status: ABORTED

Link to invocation

@yiqingy0
Copy link
Copy Markdown
Collaborator Author

yiqingy0 commented Apr 2, 2026

/bot skip --comment "Tested in LLM/dev_yiqingy/L0_MergeRequest_PR #35 and LLM/dev_yiqingy/L0_MergeRequest_PR #36"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41310 [ skip ] triggered by Bot. Commit: 40c8d06 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41310 [ skip ] completed with state SUCCESS. Commit: 40c8d06
Skipping testing for commit 40c8d06

Link to invocation

@yiqingy0 yiqingy0 requested a review from chzblych April 2, 2026 03:01
@yiqingy0 yiqingy0 dismissed chzblych’s stale review April 2, 2026 03:07

The code has been changed according the requested change.

@yiqingy0 yiqingy0 merged commit 6d8850c into NVIDIA:main Apr 2, 2026
7 of 9 checks passed
@yiqingy0 yiqingy0 deleted the fix_tot_repo branch April 2, 2026 03:09
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
…en gitlab repo (NVIDIA#11063)

Signed-off-by: Yiqing Yan <yiqingy@nvidia.com>
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Co-authored-by: Yanchao Lu <yanchaol@nvidia.com>
Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants