Skip to content

[None][test] Unwaive Nemotron H flaky case#11236

Merged
nv-guomingz merged 1 commit intoNVIDIA:mainfrom
nv-guomingz:user/guomingz/unwaive_nemotron_h_cuda_overlap_testing
Apr 7, 2026
Merged

[None][test] Unwaive Nemotron H flaky case#11236
nv-guomingz merged 1 commit intoNVIDIA:mainfrom
nv-guomingz:user/guomingz/unwaive_nemotron_h_cuda_overlap_testing

Conversation

@nv-guomingz
Copy link
Copy Markdown
Collaborator

@nv-guomingz nv-guomingz commented Feb 3, 2026

Summary by CodeRabbit

  • Tests
    • Updated test configuration to re-enable a previously skipped test case.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "H100_PCIe-PyTorch-1“

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

One skip entry was removed from the test waives list file. The deleted entry corresponds to a Nemotron H CUDA graph overlap scheduler test that is no longer being skipped.

Changes

Cohort / File(s) Summary
Test Skip List
tests/integration/test_lists/waives.txt
Removed skip entry for unittest/_torch/modeling/test_modeling_nemotron_h.py::test_nemotron_h_cuda_graph_overlap_scheduler.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete and largely empty, containing only the template structure with no substantive content in required sections. Fill in the Description section explaining why the test skip is being removed and the solution. Add Test Coverage details listing the relevant test. Complete the PR Checklist by marking the checkbox.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and specifically identifies the main change: removing a skip/waive entry for a Nemotron H CUDA graph overlap scheduler test case.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #34659 Bot args parsing error: Traceback (most recent call last):
File "bot/bin/parse_args.py", line 20, in main
args = note_handler.parse_args(shlex.split(cmd))
File "/usr/local/lib/python3.8/shlex.py", line 311, in split
return list(lex)
File "/usr/local/lib/python3.8/shlex.py", line 300, in next
token = self.get_token()
File "/usr/local/lib/python3.8/shlex.py", line 109, in get_token
raw = self.read_token()
File "/usr/local/lib/python3.8/shlex.py", line 191, in read_token
raise ValueError("No closing quotation")
ValueError: No closing quotation

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "bot/bin/parse_args.py", line 29, in
main()
File "bot/bin/parse_args.py", line 22, in main
e.with_traceback()
TypeError: with_traceback() takes exactly one argument (0 given)

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --help

@nv-guomingz nv-guomingz changed the title [None][test] Unwaive Nemotron H flaky case.wq [None][test] Unwaive Nemotron H flaky case Feb 4, 2026
@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "H100_PCIe-PyTorch-1“

@nv-guomingz nv-guomingz force-pushed the user/guomingz/unwaive_nemotron_h_cuda_overlap_testing branch from 8d2e10f to cf07a06 Compare February 4, 2026 02:33
@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "H100_PCIe-PyTorch-1“

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #34714 Bot args parsing error: Traceback (most recent call last):
File "bot/bin/parse_args.py", line 20, in main
args = note_handler.parse_args(shlex.split(cmd))
File "/usr/local/lib/python3.8/shlex.py", line 311, in split
return list(lex)
File "/usr/local/lib/python3.8/shlex.py", line 300, in next
token = self.get_token()
File "/usr/local/lib/python3.8/shlex.py", line 109, in get_token
raw = self.read_token()
File "/usr/local/lib/python3.8/shlex.py", line 191, in read_token
raise ValueError("No closing quotation")
ValueError: No closing quotation

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "bot/bin/parse_args.py", line 29, in
main()
File "bot/bin/parse_args.py", line 22, in main
e.with_traceback()
TypeError: with_traceback() takes exactly one argument (0 given)

@nv-guomingz nv-guomingz force-pushed the user/guomingz/unwaive_nemotron_h_cuda_overlap_testing branch from cf07a06 to 4b0ca41 Compare March 2, 2026 07:29
@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --stage-list "H100_PCIe-PyTorch-1“

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #37297 Bot args parsing error: Traceback (most recent call last):
File "bot/bin/parse_args.py", line 20, in main
args = note_handler.parse_args(shlex.split(cmd))
File "/usr/local/lib/python3.8/shlex.py", line 311, in split
return list(lex)
File "/usr/local/lib/python3.8/shlex.py", line 300, in next
token = self.get_token()
File "/usr/local/lib/python3.8/shlex.py", line 109, in get_token
raw = self.read_token()
File "/usr/local/lib/python3.8/shlex.py", line 191, in read_token
raise ValueError("No closing quotation")
ValueError: No closing quotation

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "bot/bin/parse_args.py", line 29, in
main()
File "bot/bin/parse_args.py", line 22, in main
e.with_traceback()
TypeError: with_traceback() takes exactly one argument (0 given)

Link to invocation

@nv-guomingz nv-guomingz force-pushed the user/guomingz/unwaive_nemotron_h_cuda_overlap_testing branch from 4b0ca41 to c88482c Compare March 17, 2026 07:42
@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@nv-guomingz nv-guomingz enabled auto-merge (squash) March 17, 2026 07:43
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39218 [ run ] triggered by Bot. Commit: c88482c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39218 [ run ] completed with state SUCCESS. Commit: c88482c
/LLM/main/L0_MergeRequest_PR pipeline #30470 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39405 [ run ] triggered by Bot. Commit: c88482c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39405 [ run ] completed with state SUCCESS. Commit: c88482c
/LLM/main/L0_MergeRequest_PR pipeline #30635 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39826 [ run ] triggered by Bot. Commit: c88482c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39826 [ run ] completed with state FAILURE. Commit: c88482c
/LLM/main/L0_MergeRequest_PR pipeline #31003 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz nv-guomingz force-pushed the user/guomingz/unwaive_nemotron_h_cuda_overlap_testing branch from c88482c to 62aa3fc Compare March 23, 2026 01:59
@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39856 [ run ] triggered by Bot. Commit: 62aa3fc Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #39856 [ run ] completed with state SUCCESS. Commit: 62aa3fc
/LLM/main/L0_MergeRequest_PR pipeline #31030 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz nv-guomingz force-pushed the user/guomingz/unwaive_nemotron_h_cuda_overlap_testing branch from 62aa3fc to 691c247 Compare March 24, 2026 05:03
@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40056 [ run ] triggered by Bot. Commit: 691c247 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40056 [ run ] completed with state SUCCESS. Commit: 691c247
/LLM/main/L0_MergeRequest_PR pipeline #31211 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40257 [ run ] triggered by Bot. Commit: 691c247 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40257 [ run ] completed with state SUCCESS. Commit: 691c247
/LLM/main/L0_MergeRequest_PR pipeline #31380 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz nv-guomingz force-pushed the user/guomingz/unwaive_nemotron_h_cuda_overlap_testing branch from 691c247 to ea0fce8 Compare April 5, 2026 11:10
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
@nv-guomingz nv-guomingz force-pushed the user/guomingz/unwaive_nemotron_h_cuda_overlap_testing branch from ea0fce8 to c6861a0 Compare April 5, 2026 11:24
@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41869 [ run ] triggered by Bot. Commit: c6861a0 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41869 [ run ] completed with state SUCCESS. Commit: c6861a0
/LLM/main/L0_MergeRequest_PR pipeline #32735 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@nv-guomingz
Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42028 [ run ] triggered by Bot. Commit: c6861a0 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42028 [ run ] completed with state SUCCESS. Commit: c6861a0
/LLM/main/L0_MergeRequest_PR pipeline #32874 completed with status: 'SUCCESS'

CI Report

Link to invocation

@nv-guomingz nv-guomingz requested a review from EmmaQiaoCh April 7, 2026 09:18
@nv-guomingz nv-guomingz merged commit 63cb1f9 into NVIDIA:main Apr 7, 2026
5 checks passed
karen-sy pushed a commit to karen-sy/TensorRT-LLM that referenced this pull request Apr 7, 2026
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
suyoggupta pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Apr 8, 2026
Signed-off-by: nv-guomingz <137257613+nv-guomingz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants