[None][doc] Update media files path in Skip Softmax blog.#11540
[None][doc] Update media files path in Skip Softmax blog.#11540bobboli merged 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Bo Li <22713281+bobboli@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughA blog markdown file was updated to replace relative image paths with absolute GitHub raw URLs. The change affects only image source references in documentation, with no modifications to code logic, functionality, or control flow. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
docs/source/blogs/tech_blog/blog16_Accelerating_Long_Context_Inference_with_Skip_Softmax_Attention.md (2)
155-164: Consider pinning raw image URLs to a commit SHA.Same concern here:
raw/mainis mutable. Pinning to a commit hash avoids future image breaks.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/source/blogs/tech_blog/blog16_Accelerating_Long_Context_Inference_with_Skip_Softmax_Attention.md` around lines 155 - 164, The image tags in the markdown use mutable raw/main URLs which can break; update each <img> src (e.g., the URLs containing tech_blog16_hopper_prefill.png, tech_blog16_hopper_decode.png, tech_blog16_blackwell_prefill.png, tech_blog16_blackwell_decode.png) to point to the repository raw URL pinned to a specific commit SHA (replace raw/main with raw/<commit-SHA> for each image) so the images remain stable.
31-33: Consider pinning raw image URLs to a commit SHA.Pointing to
raw/maincan break if files are moved or renamed later. Pinning to a commit hash keeps blog images stable.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/source/blogs/tech_blog/blog16_Accelerating_Long_Context_Inference_with_Skip_Softmax_Attention.md` around lines 31 - 33, The image src currently points to a mutable raw/main URL which can break if files move; update the img tag's src attribute (the <img ... src="..."> line referencing tech_blog16_blasst.jpg) to pin the file to a specific commit by replacing the raw/main path with raw/<commit-sha> (e.g., raw/<commit-hash>) so the blog image URL references a stable commit SHA; commit the change and verify the image still loads.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In
`@docs/source/blogs/tech_blog/blog16_Accelerating_Long_Context_Inference_with_Skip_Softmax_Attention.md`:
- Around line 155-164: The image tags in the markdown use mutable raw/main URLs
which can break; update each <img> src (e.g., the URLs containing
tech_blog16_hopper_prefill.png, tech_blog16_hopper_decode.png,
tech_blog16_blackwell_prefill.png, tech_blog16_blackwell_decode.png) to point to
the repository raw URL pinned to a specific commit SHA (replace raw/main with
raw/<commit-SHA> for each image) so the images remain stable.
- Around line 31-33: The image src currently points to a mutable raw/main URL
which can break if files move; update the img tag's src attribute (the <img ...
src="..."> line referencing tech_blog16_blasst.jpg) to pin the file to a
specific commit by replacing the raw/main path with raw/<commit-sha> (e.g.,
raw/<commit-hash>) so the blog image URL references a stable commit SHA; commit
the change and verify the image still loads.
|
PR_Github #36065 [ run ] triggered by Bot. Commit: |
|
PR_Github #36065 [ run ] completed with state |
|
/bot run |
|
PR_Github #36081 [ run ] triggered by Bot. Commit: |
|
PR_Github #36081 [ run ] completed with state |
3 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.