Skip to content

Comments

[#11569][fix] Fix broken LLMAPI config#11571

Merged
2ez4bz merged 1 commit intoNVIDIA:mainfrom
2ez4bz:dev-fix-curated-config
Feb 20, 2026
Merged

[#11569][fix] Fix broken LLMAPI config#11571
2ez4bz merged 1 commit intoNVIDIA:mainfrom
2ez4bz:dev-fix-curated-config

Conversation

@2ez4bz
Copy link
Collaborator

@2ez4bz 2ez4bz commented Feb 18, 2026

Summary by CodeRabbit

  • Chores
    • Restructured GPU memory cache configuration in example configuration files to improve parameter organization and maintainability while preserving all values.

Fix broken LLMAPI config

This fixes the issue uncovered here.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: William Zhang <133824995+2ez4bz@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

📝 Walkthrough

Walkthrough

A configuration file restructuring that nests the KV cache free GPU memory fraction parameter under a new kv_cache_config dictionary instead of maintaining it as a top-level key. The parameter value and functionality remain unchanged.

Changes

Cohort / File(s) Summary
Configuration restructuring
examples/configs/curated/qwen3.yaml
Moved kv_cache_free_gpu_memory_fraction from top-level key to nested kv_cache_config dictionary structure, changing the configuration path from direct access to nested access.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description links to the issue but lacks detail on what the actual problem is and how the nested kv_cache_config change resolves it; Test Coverage section is empty. Add a brief explanation of the specific configuration issue (nested kv_cache_config change) and list relevant tests that validate the fix.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[#11569][fix] Fix broken LLMAPI config' clearly and specifically identifies the main change as a fix to an LLMAPI configuration, following the repository's template format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@examples/configs/curated/qwen3.yaml`:
- Around line 3-4: The new config uses a nested key
(kv_cache_config.free_gpu_memory_fraction) while eight other curated configs
still use the flat top-level key kv_cache_free_gpu_memory_fraction, leaving the
repo inconsistent; either (A) update the other curated YAMLs to the nested
structure so all configs use kv_cache_config.free_gpu_memory_fraction, or (B)
make the config loader accept both patterns by checking for
kv_cache_config.free_gpu_memory_fraction first and falling back to
kv_cache_free_gpu_memory_fraction (or vice versa) and normalizing into one
internal field; reference the keys kv_cache_config, free_gpu_memory_fraction,
and kv_cache_free_gpu_memory_fraction when making the change.

@2ez4bz
Copy link
Collaborator Author

2ez4bz commented Feb 18, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #36178 [ run ] triggered by Bot. Commit: 5110627 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #36178 [ run ] completed with state FAILURE. Commit: 5110627
/LLM/main/L0_MergeRequest_PR pipeline #27961 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@wzhao18
Copy link

wzhao18 commented Feb 19, 2026

Thanks for the fix. I've seen other places of the repo using the same old pattern, e.g., https://github.com/NVIDIA/TensorRT-LLM/tree/main/examples/configs/curated. It would be great to fix all of them.

@2ez4bz
Copy link
Collaborator Author

2ez4bz commented Feb 20, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #36313 [ run ] triggered by Bot. Commit: 5110627 Link to invocation

@2ez4bz 2ez4bz enabled auto-merge (squash) February 20, 2026 06:39
@tensorrt-cicd
Copy link
Collaborator

PR_Github #36313 [ run ] completed with state SUCCESS. Commit: 5110627
/LLM/main/L0_MergeRequest_PR pipeline #28085 completed with status: 'SUCCESS'

Link to invocation

@2ez4bz 2ez4bz merged commit c2f840d into NVIDIA:main Feb 20, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants