Skip to content

[None][infra] Waive failed cases for main on 02/27#11770

Merged
EmmaQiaoCh merged 1 commit intoNVIDIA:mainfrom
EmmaQiaoCh:emma/waive_main_0227
Feb 27, 2026
Merged

[None][infra] Waive failed cases for main on 02/27#11770
EmmaQiaoCh merged 1 commit intoNVIDIA:mainfrom
EmmaQiaoCh:emma/waive_main_0227

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Feb 27, 2026

Summary by CodeRabbit

  • Chores
    • Added test waivers for disaggregated performance checks across multiple configurations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh
Copy link
Collaborator Author

/bot skip --comment "Waive failed cases for main"

@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) February 27, 2026 03:05
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6f7138a and 40c653f.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Nine SKIP waiver entries are added to the test waivers file for disaggregated performance checks covering gb200_gpt-oss-120b-fp4 across multiple context size configurations without any logic changes elsewhere.

Changes

Cohort / File(s) Summary
Test Waivers
tests/integration/test_lists/waives.txt
Added 9 new SKIP waiver entries for disaggregated upload-gen_only-gb200 variants across different context sizes (512, 64, 128, 4, 3072) and related deepseek/qp configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • pcastonguay
  • chzblych
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete, containing only the template structure with no actual description of changes, test coverage, or rationale filled in by the author. Provide a description explaining why these test cases are being waived, what specific issues they address, and any relevant context for the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary change: adding waivers for failed test cases on the specified date. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37006 [ skip ] triggered by Bot. Commit: 40c653f Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37006 [ skip ] completed with state SUCCESS. Commit: 40c653f
Skipping testing for commit 40c653f

Link to invocation

@EmmaQiaoCh EmmaQiaoCh merged commit 57c2904 into NVIDIA:main Feb 27, 2026
8 of 9 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants