[None][refactor] Request management in ScheduledRequests#11784
[None][refactor] Request management in ScheduledRequests#11784Funatiq merged 4 commits intoNVIDIA:mainfrom
Conversation
|
/bot run |
|
PR_Github #37069 [ run ] triggered by Bot. Commit: |
0c95753 to
c9aecea
Compare
|
/bot run |
|
PR_Github #37072 [ run ] triggered by Bot. Commit: |
|
PR_Github #37072 [ run ] completed with state
|
c9aecea to
a10d4bb
Compare
|
/bot run |
|
PR_Github #37087 [ run ] triggered by Bot. Commit: |
|
PR_Github #37087 [ run ] completed with state
|
a10d4bb to
82372d1
Compare
|
/bot run |
|
PR_Github #37167 [ run ] triggered by Bot. Commit: |
|
PR_Github #37167 [ run ] completed with state
|
82372d1 to
ba0482f
Compare
|
/bot run |
|
PR_Github #37176 [ run ] triggered by Bot. Commit: |
|
PR_Github #37176 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #37181 [ run ] triggered by Bot. Commit: |
|
PR_Github #37181 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #37210 [ run ] triggered by Bot. Commit: |
|
PR_Github #37210 [ run ] completed with state
|
|
/bot run |
|
PR_Github #37219 [ run ] triggered by Bot. Commit: |
|
PR_Github #37219 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #37234 [ run ] triggered by Bot. Commit: |
eopXD
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you.
|
PR_Github #37819 [ run ] completed with state
|
28f118c to
44f1fef
Compare
|
/bot skip --comment "All tests passed in last pipeline. Only release check was failing and was fixed in main." |
|
PR_Github #37831 [ skip ] triggered by Bot. Commit: |
|
PR_Github #37831 [ skip ] completed with state |
7c9f79e to
1bbe808
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #37996 [ run ] triggered by Bot. Commit: |
- Separate context requests into chunking and last chunk lists. - Add context_requests property to combine chunking and last chunk lists. - Add num_context_requests and num_generation_requests properties. - Add scheduled requests to BatchState. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
- Introduce append_context_request and append_generation_request functions for ScheduledRequests. - Append context requests to the appropriate lists in the ScheduledRequests object. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
ff52270 to
d668f0b
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #37996 [ run ] completed with state
|
|
PR_Github #38045 [ run ] triggered by Bot. Commit: |
|
PR_Github #38045 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #38065 [ run ] triggered by Bot. Commit: |
|
PR_Github #38065 [ run ] completed with state |
Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Summary by CodeRabbit
Release Notes
Refactoring & Improvements
Description
The main changes are:
ScheduledRequestsforcontext_requests_chunkingandcontext_requests_last_chunkScheduledRequestsseparately inBatchStateandSampleState(this is a preparation to selecting the requests that should run the sampling)Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.