[https://nvbugs/5911788][test] Waive test_llm_partial_update_weights[Qwen3/Qwen3-8B]#11785
Conversation
…Qwen3/Qwen3-8B] Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
📝 WalkthroughWalkthroughAdded a single test skip entry to the waives list for a specific test case with an associated bug reference, with no functional code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
336-336: LGTM! Test waiver properly added with valid bug reference.The test skip entry is correctly formatted and logically grouped with related waivers for bug 5911788. Based on learnings, the project prefers the short URL format
https://nvbugs/5911788over the long format, but your entry is consistent with the adjacent lines (331-335) for the same bug.Optional: Consider short URL format for future additions
For consistency with project conventions, the short format is preferred:
-unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-8B] SKIP (https://nvbugspro.nvidia.com/bug/5911788) +unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-8B] SKIP (https://nvbugs/5911788)However, this would ideally be done for all entries referencing bug 5911788 (lines 331-336) to maintain local consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/test_lists/waives.txt` at line 336, Replace the long NVIDIA bug URL in the waiver entry for unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-8B] with the project-preferred short format (use https://nvbugs/5911788), and apply the same short URL to the nearby waiver entries that reference the same bug (the adjacent lines that reference bug 5911788) so all local entries are consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 336: Replace the long NVIDIA bug URL in the waiver entry for
unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-8B]
with the project-preferred short format (use https://nvbugs/5911788), and apply
the same short URL to the nearby waiver entries that reference the same bug (the
adjacent lines that reference bug 5911788) so all local entries are consistent.
…Qwen3/Qwen3-8B] (NVIDIA#11785) Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.