Skip to content

[https://nvbugs/5911788][test] Waive test_llm_partial_update_weights[Qwen3/Qwen3-8B]#11785

Merged
chzblych merged 1 commit intoNVIDIA:mainfrom
liji-nv:waive-partial-update-weights-qwen3-8b
Feb 27, 2026
Merged

[https://nvbugs/5911788][test] Waive test_llm_partial_update_weights[Qwen3/Qwen3-8B]#11785
chzblych merged 1 commit intoNVIDIA:mainfrom
liji-nv:waive-partial-update-weights-qwen3-8b

Conversation

@liji-nv
Copy link
Collaborator

@liji-nv liji-nv commented Feb 27, 2026

Summary by CodeRabbit

  • Chores
    • Updated test skip configuration to manage test execution in the testing infrastructure.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…Qwen3/Qwen3-8B]

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 27, 2026

📝 Walkthrough

Walkthrough

Added a single test skip entry to the waives list for a specific test case with an associated bug reference, with no functional code changes.

Changes

Cohort / File(s) Summary
Test Skip Configuration
tests/integration/test_lists/waives.txt
Added skip entry for test_llm_partial_update_weights[Qwen3/Qwen3-8B] with bug reference 5911788.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is completely empty except for the template structure; no actual content, rationale, or test coverage information was provided by the author. Fill in the Description section with an explanation of why the test is being waived. Complete the Test Coverage section listing the affected test and any related tests.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly specifies the main change: waiving a specific test (test_llm_partial_update_weights[Qwen3/Qwen3-8B]) and references the associated bug ticket, directly matching the changeset which adds this test skip entry to the waives list.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)

336-336: LGTM! Test waiver properly added with valid bug reference.

The test skip entry is correctly formatted and logically grouped with related waivers for bug 5911788. Based on learnings, the project prefers the short URL format https://nvbugs/5911788 over the long format, but your entry is consistent with the adjacent lines (331-335) for the same bug.

Optional: Consider short URL format for future additions

For consistency with project conventions, the short format is preferred:

-unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-8B] SKIP (https://nvbugspro.nvidia.com/bug/5911788)
+unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-8B] SKIP (https://nvbugs/5911788)

However, this would ideally be done for all entries referencing bug 5911788 (lines 331-336) to maintain local consistency.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@tests/integration/test_lists/waives.txt` at line 336, Replace the long NVIDIA
bug URL in the waiver entry for
unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-8B]
with the project-preferred short format (use https://nvbugs/5911788), and apply
the same short URL to the nearby waiver entries that reference the same bug (the
adjacent lines that reference bug 5911788) so all local entries are consistent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 336: Replace the long NVIDIA bug URL in the waiver entry for
unittest/_torch/ray_orchestrator/single_gpu/test_llm_update_weights.py::test_llm_partial_update_weights[Qwen3/Qwen3-8B]
with the project-preferred short format (use https://nvbugs/5911788), and apply
the same short URL to the nearby waiver entries that reference the same bug (the
adjacent lines that reference bug 5911788) so all local entries are consistent.

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c2d766b and bb55aa6.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

@chzblych chzblych changed the title [https://nvbugs/5911788][test] Waive test_llm_partial_update_weights[… [https://nvbugs/5911788][test] Waive test_llm_partial_update_weights[Qwen3/Qwen3-8B] Feb 27, 2026
@chzblych chzblych merged commit 985f81d into NVIDIA:main Feb 27, 2026
10 of 12 checks passed
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 9, 2026
…Qwen3/Qwen3-8B] (NVIDIA#11785)

Signed-off-by: Jin Li <59594262+liji-nv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants