[None][fix] Cherry pick cancel fix

[pcastonguay]

Summary by CodeRabbit

• Bug Fixes
  • Resolved an issue where generation-only requests would emit responses after completion.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

[pcastonguay]

/bot run --disable-fail-fast

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 630fccb and 3e67f2a.

📒 Files selected for processing (1)

• tensorrt_llm/_torch/pyexecutor/py_executor.py

---

📝 Walkthrough

Walkthrough

A single-line conditional check is added to the _handle_responses method to prevent emitting responses for generation-only requests that have already completed. This refines the response finalization logic without altering public APIs.

Changes

Cohort / File(s)	Summary
Response Handling Logic tensorrt_llm/_torch/pyexecutor/py_executor.py	Added a condition check to guard against emitting responses for generation-only requests that have already finished, ensuring responses are only emitted for active requests.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description contains only the template placeholder text with no concrete explanation of the issue, solution, test coverage, or rationale provided by the author.	Fill in the Description section explaining what cancel-related bug is being fixed and why, and provide concrete test coverage details under Test Coverage.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title '[None][fix] Cherry pick cancel fix' follows the correct template format with [None] ticket indicator and [fix] type, and references the main intent of cherry-picking cancel/cancellation fixes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #37105 [ run ] triggered by Bot. Commit: 3e67f2a Link to invocation

[tensorrt-cicd]

PR_Github #37105 [ run ] completed with state SUCCESS. Commit: 3e67f2a
/LLM/release-1.3.0rc5.post1/L0_MergeRequest_PR pipeline #2 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

[Tabrizian]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #37136 [ run ] triggered by Bot. Commit: 3e67f2a Link to invocation

[pcastonguay]

/bot kill

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #37227 [ run ] triggered by Bot. Commit: 3e67f2a Link to invocation

[tensorrt-cicd]

PR_Github #37227 [ run ] completed with state SUCCESS. Commit: 3e67f2a
/LLM/release-1.3.0rc5.post1/L0_MergeRequest_PR pipeline #6 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #37240 [ run ] triggered by Bot. Commit: 3e67f2a Link to invocation

[tensorrt-cicd]

PR_Github #37240 [ run ] completed with state SUCCESS. Commit: 3e67f2a
/LLM/release-1.3.0rc5.post1/L0_MergeRequest_PR pipeline #7 completed with status: 'FAILURE'

⚠️ Action Required:

• Please check the failed tests and fix your PR
• If you cannot view the failures, ask the CI triggerer to share details
• Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #37247 [ run ] triggered by Bot. Commit: 3e67f2a Link to invocation

[tensorrt-cicd]

PR_Github #37247 [ run ] completed with state SUCCESS. Commit: 3e67f2a
/LLM/release-1.3.0rc5.post1/L0_MergeRequest_PR pipeline #8 completed with status: 'SUCCESS'

Link to invocation