Skip to content

[None][chore] Handle failure in auto-assign author workflow#11906

Merged
zhenhuaw-me merged 1 commit intoNVIDIA:mainfrom
zhenhuaw-me:fix-action
Mar 4, 2026
Merged

[None][chore] Handle failure in auto-assign author workflow#11906
zhenhuaw-me merged 1 commit intoNVIDIA:mainfrom
zhenhuaw-me:fix-action

Conversation

@zhenhuaw-me
Copy link
Member

@zhenhuaw-me zhenhuaw-me commented Mar 4, 2026

Can only assign to members or collaborators.

Summary by CodeRabbit

  • Chores
    • Enhanced GitHub workflow robustness by improving error handling in the PR assignment step. The workflow now gracefully skips assignment when the assignee isn't a collaborator, preventing workflow failures while providing informative feedback.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Can only assign to members or collaborators.

Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
@zhenhuaw-me zhenhuaw-me marked this pull request as ready for review March 4, 2026 09:10
@zhenhuaw-me zhenhuaw-me requested review from a team as code owners March 4, 2026 09:10
@zhenhuaw-me zhenhuaw-me requested review from ZhanruiSunCh and kxdc March 4, 2026 09:10
@zhenhuaw-me
Copy link
Member Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 4, 2026

📝 Walkthrough

Walkthrough

The GitHub Actions workflow for auto-assigning PRs to authors now includes fallback error handling. The gh pr edit command is modified to gracefully skip assignment if it fails, logging an informational message instead of failing the entire workflow step.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/auto-assign-author.yml
Added fallback error handling using || echo to prevent workflow failure when PR author assignment fails due to insufficient permissions or collaborator status.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. It contains only a brief explanation ('Can only assign to members or collaborators') and the template with empty sections, missing required details like the actual problem description, solution, and test coverage. Fill in the Description section explaining the issue and solution, add Test Coverage details, and complete the PR Checklist to meet template requirements.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding error handling to the auto-assign author workflow to prevent failures when assignment targets aren't collaborators.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/auto-assign-author.yml:
- Line 18: The current step runs "gh pr edit $PR_URL --add-assignee $AUTHOR ||
echo ..." which masks all failures; replace this with a preflight assignability
check using the REST endpoint GET /repos/{owner}/{repo}/assignees/{assignee}
(via gh api or curl) to detect 204 (assignable) vs 404 (not assignable), only
call "gh pr edit $PR_URL --add-assignee $AUTHOR" when the preflight returns 204,
and allow any other HTTP or gh errors to fail the job so token/permission/API
failures are not hidden.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ba67388c-1715-40a2-8481-09991e8db1d0

📥 Commits

Reviewing files that changed from the base of the PR and between d3536f1 and 6c6c036.

📒 Files selected for processing (1)
  • .github/workflows/auto-assign-author.yml

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37673 [ run ] triggered by Bot. Commit: 6c6c036 Link to invocation

@zhenhuaw-me zhenhuaw-me enabled auto-merge (squash) March 4, 2026 09:43
@tensorrt-cicd
Copy link
Collaborator

PR_Github #37673 [ run ] completed with state SUCCESS. Commit: 6c6c036
/LLM/main/L0_MergeRequest_PR pipeline #29156 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@zhenhuaw-me
Copy link
Member Author

/bot skip

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@zhenhuaw-me
Copy link
Member Author

/bot skip --comment "This is a GitHub action change which doesn't impact TRT-LLM functionality"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37701 Bot args parsing error: Failed to parse bot args

Link to invocation

@zhenhuaw-me
Copy link
Member Author

/bot skip --comment "unrelated failures"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37703 [ skip ] triggered by Bot. Commit: 6c6c036 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37703 [ skip ] completed with state SUCCESS. Commit: 6c6c036
Skipping testing for commit 6c6c036

Link to invocation

@zhenhuaw-me zhenhuaw-me merged commit e0f54b3 into NVIDIA:main Mar 4, 2026
8 of 10 checks passed
@zhenhuaw-me zhenhuaw-me deleted the fix-action branch March 4, 2026 13:57
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 9, 2026
…1906)

Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants