[None][chore] Handle failure in auto-assign author workflow#11906
[None][chore] Handle failure in auto-assign author workflow#11906zhenhuaw-me merged 1 commit intoNVIDIA:mainfrom
Conversation
Can only assign to members or collaborators. Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughThe GitHub Actions workflow for auto-assigning PRs to authors now includes fallback error handling. The Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/auto-assign-author.yml:
- Line 18: The current step runs "gh pr edit $PR_URL --add-assignee $AUTHOR ||
echo ..." which masks all failures; replace this with a preflight assignability
check using the REST endpoint GET /repos/{owner}/{repo}/assignees/{assignee}
(via gh api or curl) to detect 204 (assignable) vs 404 (not assignable), only
call "gh pr edit $PR_URL --add-assignee $AUTHOR" when the preflight returns 204,
and allow any other HTTP or gh errors to fail the job so token/permission/API
failures are not hidden.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ba67388c-1715-40a2-8481-09991e8db1d0
📒 Files selected for processing (1)
.github/workflows/auto-assign-author.yml
|
PR_Github #37673 [ run ] triggered by Bot. Commit: |
|
PR_Github #37673 [ run ] completed with state
|
|
/bot skip |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot skip --comment "This is a GitHub action change which doesn't impact TRT-LLM functionality" |
|
PR_Github #37701 Bot args parsing error: Failed to parse bot args |
|
/bot skip --comment "unrelated failures" |
|
PR_Github #37703 [ skip ] triggered by Bot. Commit: |
|
PR_Github #37703 [ skip ] completed with state |
…1906) Signed-off-by: Zhenhua Wang <4936589+zhenhuaw-me@users.noreply.github.com>
Can only assign to members or collaborators.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.