Skip to content

[https://nvbugs/5819048][fix] unwaive test of qwen3-235b eagle3#11969

Merged
byshiue merged 1 commit intoNVIDIA:mainfrom
byshiue:fix/nvbug_5819048
Mar 6, 2026
Merged

[https://nvbugs/5819048][fix] unwaive test of qwen3-235b eagle3#11969
byshiue merged 1 commit intoNVIDIA:mainfrom
byshiue:fix/nvbug_5819048

Conversation

@byshiue
Copy link
Collaborator

@byshiue byshiue commented Mar 6, 2026

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously skipped test by removing it from the test waives list.

Description

Test Coverage

accuracy/test_llm_api_pytorch.py::TestQwen3_235B_A22B::test_nvfp4_4gpus[latency_moe_trtllm_eagle3]

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

…_eagle3]

Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com>
@byshiue
Copy link
Collaborator Author

byshiue commented Mar 6, 2026

/bot run --post-merge --stage-list "GB200-4_GPUs-PyTorch-Post-Merge-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

📝 Walkthrough

Walkthrough

Removed a single test skip entry from the waives list configuration file. This modification only affects test execution skipping and has no impact on production code or runtime behavior.

Changes

Cohort / File(s) Summary
Test Skip List
tests/integration/test_lists/waives.txt
Removed one SKIP entry for accuracy/test_llm_api_pytorch.py::TestQwen3_235B_A22B::test_nvfp4_4gpus[latency_moe_trtllm_eagle3], allowing this test to run instead of being skipped.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely empty with only the test coverage field filled; the Description section and PR title are missing. Add a proper PR title following the template format and provide a clear description explaining the issue and why the test is being unwaived.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a SKIP entry to unwaive a test for Qwen3-235B Eagle3, with the NVBugs issue reference provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37955 [ run ] triggered by Bot. Commit: 31234c6 Link to invocation

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37955 [ run ] completed with state SUCCESS. Commit: 31234c6
/LLM/main/L0_MergeRequest_PR pipeline #29394 (Partly Tested) completed with status: 'SUCCESS'

Link to invocation

@byshiue
Copy link
Collaborator Author

byshiue commented Mar 6, 2026

/bot skip --comment "the eagle3 test of qwen3-235B has passed"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #37985 [ skip ] triggered by Bot. Commit: 31234c6 Link to invocation

@byshiue byshiue enabled auto-merge (squash) March 6, 2026 06:57
@tensorrt-cicd
Copy link
Collaborator

PR_Github #37985 [ skip ] completed with state SUCCESS. Commit: 31234c6
Skipping testing for commit 31234c6

Link to invocation

@byshiue byshiue merged commit f639e8b into NVIDIA:main Mar 6, 2026
8 of 10 checks passed
@byshiue byshiue deleted the fix/nvbug_5819048 branch March 6, 2026 07:26
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Mar 9, 2026
…IA#11969)

Signed-off-by: bhsueh <11360707+byshiue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants