Skip to content

[None][chore] waive test_visual_gen_quickstart#12043

Merged
tburt-nv merged 1 commit intoNVIDIA:mainfrom
tburt-nv:user/tburt/waive_visual
Mar 9, 2026
Merged

[None][chore] waive test_visual_gen_quickstart#12043
tburt-nv merged 1 commit intoNVIDIA:mainfrom
tburt-nv:user/tburt/waive_visual

Conversation

@tburt-nv
Copy link
Collaborator

@tburt-nv tburt-nv commented Mar 9, 2026

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Chores
    • Updated internal test skip configurations.

No user-facing changes.

Signed-off-by: Tyler Burt <195370667+tburt-nv@users.noreply.github.com>
@tburt-nv
Copy link
Collaborator Author

tburt-nv commented Mar 9, 2026

/bot skip --comment "waive only to unblock L0"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 9, 2026

📝 Walkthrough

Walkthrough

Added duplicate SKIP entries to the test waive list for test_examples/test_visual_gen.py::test_visual_gen_quickstart. No functional changes or control flow modifications.

Changes

Cohort / File(s) Summary
Test Waive List
tests/integration/test_lists/waives.txt
Added two identical SKIP entries for the visual generation quickstart test to the waive list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is empty with no explanation of the issue, solution, or test coverage. Only the template structure is present with no content filling. Add a meaningful description explaining why test_visual_gen_quickstart is being waived, what issue it addresses, and any relevant test coverage information.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the main change: adding a waiver for test_visual_gen_quickstart to the skip list.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #38297 [ skip ] triggered by Bot. Commit: 40294f0 Link to invocation

@tburt-nv tburt-nv enabled auto-merge (squash) March 9, 2026 16:48
@tburt-nv
Copy link
Collaborator Author

tburt-nv commented Mar 9, 2026

pre-commit checks passed in GitHub actions, merging now

@tburt-nv tburt-nv disabled auto-merge March 9, 2026 17:16
@tburt-nv tburt-nv merged commit 3b82b6c into NVIDIA:main Mar 9, 2026
7 of 10 checks passed
@tensorrt-cicd
Copy link
Collaborator

PR_Github #38297 [ skip ] completed with state SUCCESS. Commit: 40294f0
Skipping testing for commit 40294f0

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants