[None][test] update function multi nodes test#12075
Conversation
275d32e to
8969c1f
Compare
|
/bot run --skip-test |
📝 WalkthroughWalkthroughThe changes remove the "trtllm-llmapi-launch" wrapper from test command invocations, reduce timeout values from 7200 to 5400 seconds, adjust multi-node test parameterization, and remove multiple test cases and entire test functions from the multinode test matrix to narrow coverage scope. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/test_e2e.py (1)
3063-3068:⚠️ Potential issue | 🟡 MinorStale comment:
trtllm-llmapi-launchwrapper has been removed.The comment on line 3063-3064 states "run the command with trtllm-llmapi-launch pytest wrapper" but the wrapper has been removed from
run_cmd. The comment should be updated or removed to avoid confusion.📝 Proposed fix
try: - # run the command with trtllm-llmapi-launch pytest wrapper + # run the evaluation command output = subprocess.check_output(run_cmd, text=True, stderr=subprocess.STDOUT, timeout=5400)🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/defs/test_e2e.py` around lines 3063 - 3068, Update the stale comment near the subprocess invocation: remove or replace the phrase referencing the removed "trtllm-llmapi-launch pytest wrapper" and ensure the comment reflects the actual behavior of run_cmd (the command being executed) used with subprocess.check_output; locate the block around run_cmd and the try/except that calls subprocess.check_output and change the comment to a concise, accurate description of what run_cmd does (or delete the comment if redundant).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@tests/integration/defs/test_e2e.py`:
- Around line 3063-3068: Update the stale comment near the subprocess
invocation: remove or replace the phrase referencing the removed
"trtllm-llmapi-launch pytest wrapper" and ensure the comment reflects the actual
behavior of run_cmd (the command being executed) used with
subprocess.check_output; locate the block around run_cmd and the try/except that
calls subprocess.check_output and change the comment to a concise, accurate
description of what run_cmd does (or delete the comment if redundant).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5a46c04d-3a34-4bfd-ab36-127e88c57605
📒 Files selected for processing (2)
tests/integration/defs/test_e2e.pytests/integration/test_lists/qa/llm_function_multinode.txt
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/qa/llm_function_multinode.txt
|
PR_Github #39033 [ run ] triggered by Bot. Commit: |
|
PR_Github #39033 [ run ] completed with state
|
|
/bot run --skip-test |
1 similar comment
|
/bot run --skip-test |
|
PR_Github #39039 [ run ] triggered by Bot. Commit: |
|
PR_Github #39040 [ run ] triggered by Bot. Commit: |
|
PR_Github #39039 [ run ] completed with state |
|
PR_Github #39040 [ run ] completed with state
|
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
|
/bot run --skip-test |
|
PR_Github #39055 [ run ] triggered by Bot. Commit: |
|
PR_Github #39081 [ run ] triggered by Bot. Commit: |
|
PR_Github #39081 [ run ] completed with state |
|
/bot run --skip-test |
|
PR_Github #39154 [ run ] triggered by Bot. Commit: |
|
/bot run --skip-test |
|
PR_Github #39162 [ run ] triggered by Bot. Commit: |
|
/bot run --skip-test |
|
PR_Github #39166 [ run ] triggered by Bot. Commit: |
|
PR_Github #39166 [ run ] completed with state
|
|
/bot reuse-pipeline --number 12075 |
|
PR_Github #39349 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #39349 [ reuse-pipeline ] completed with state |
|
/bot run --stage-list "" |
|
PR_Github #39363 [ run ] triggered by Bot. Commit: |
|
PR_Github #39363 [ run ] completed with state |
|
/bot reuse-pipeline |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot reuse-pipeline |
|
PR_Github #39389 [ reuse-pipeline ] triggered by Bot. Commit: |
|
PR_Github #39389 [ reuse-pipeline ] completed with state |
Signed-off-by: Xin He (SW-GPU) <200704525+xinhe-nv@users.noreply.github.com>
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.