[None][docs] Update nemotron 3 super deployment to include tool calling and reasoning parser#12215
Conversation
…ng and reasoning parser Signed-off-by: Joyjit Daw <1127155+tijyojwad@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughDocumentation updates to deployment and example guides for Nemotron Super, adding Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/models/core/nemotron/README_nemotron_super_v3.md`:
- Around line 121-126: Replace the deprecated flag in the example CLI
invocation: in the trtllm-serve command shown (the line containing
--extra_llm_api_options ./extra-llm-api-config.yml), change the flag to --config
so the command uses --config ./extra-llm-api-config.yml; update any adjacent
text that references --extra_llm_api_options to use --config and ensure the
example aligns with the documented CLI preference for trtllm-serve.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7f2f29ee-ff22-4cad-aa3c-78c0fce5efd2
📒 Files selected for processing (2)
docs/source/deployment-guide/deployment-guide-for-nemotron-3-super-on-trtllm.mdexamples/models/core/nemotron/README_nemotron_super_v3.md
|
PR_Github #38953 [ run ] triggered by Bot. Commit: |
|
PR_Github #38953 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #39150 [ run ] triggered by Bot. Commit: |
|
PR_Github #39150 [ run ] completed with state |
…ng and reasoning parser (NVIDIA#12215) Signed-off-by: Joyjit Daw <1127155+tijyojwad@users.noreply.github.com>
…ng and reasoning parser
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.