[https://nvbugs/5895249][fix] Update test waives#12247
Conversation
Signed-off-by: greg-kwasniewski1 <213329731+greg-kwasniewski1@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughRemoved two SKIP entries from a test waives list, un-skipping the NemotronNanoV3 accuracy test (nvfp4-4-trtllm) in autodeploy contexts. No behavioral or control-flow changes; purely a test exclusion annotation removal. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
PR_Github #39107 [ run ] triggered by Bot. Commit: |
|
PR_Github #39107 [ run ] completed with state
|
|
/bot --help |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
1 similar comment
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --disable-fail-fast |
|
PR_Github #39124 [ run ] triggered by Bot. Commit: |
|
PR_Github #39124 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #39300 [ run ] triggered by Bot. Commit: |
|
PR_Github #39300 [ run ] completed with state |
|
/bot run --disable-fail-fast --only-multi-gpu-test |
|
PR_Github #39321 [ run ] triggered by Bot. Commit: |
|
PR_Github #39321 [ run ] completed with state
|
|
/bot run --disable-fail-fast --only-multi-gpu-test |
|
PR_Github #39449 [ run ] triggered by Bot. Commit: |
|
PR_Github #39449 [ run ] completed with state
|
|
/bot run --disable-fail-fast --reuse-test --add-multi-gpu-test |
|
/bot run --disable-fail-fast --reuse-test --add-multi-gpu-test |
|
PR_Github #39631 [ run ] triggered by Bot. Commit: |
|
PR_Github #39631 [ run ] completed with state |
After merging the fix, #11618, the test should be unwaived.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.