[#10607][feat] added AutoDeploy serving perf test with Super test#12287
[#10607][feat] added AutoDeploy serving perf test with Super test#12287MrGeva merged 6 commits intoNVIDIA:mainfrom
Conversation
📝 WalkthroughWalkthroughExtended ServerConfig class with two new configurable attributes ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/integration/defs/perf/test_perf_sanity.py (1)
1-1:⚠️ Potential issue | 🟠 MajorUpdate the copyright header year to include 2026.
This file has meaningful modifications in this PR, so the latest year in the NVIDIA Apache-2.0 header should be updated.
As per coding guidelines:
**/*.{cpp,h,cu,cuh,hpp,py}: All TensorRT-LLM source files should contain an NVIDIA copyright header with the year of the latest meaningful modification.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/defs/perf/test_perf_sanity.py` at line 1, Update the SPDX copyright header at the top of the file (the existing SPDX-FileCopyrightText header line) to include 2026 as the latest year; specifically modify the header string in tests/integration/defs/perf/test_perf_sanity.py so the year range reads 2022-2026.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration/defs/perf/test_perf_sanity.py`:
- Line 332: ServerConfig.to_match_keys() is missing the persisted
s_serving_backend, causing baselines to mix across serving backends; update the
to_match_keys method to include s_serving_backend in the returned match-key
tuple or dict alongside the existing keys so comparisons account for serving
backend differences and ensure unique matching by backend (refer to the
ServerConfig.to_match_keys function and the s_serving_backend field).
---
Outside diff comments:
In `@tests/integration/defs/perf/test_perf_sanity.py`:
- Line 1: Update the SPDX copyright header at the top of the file (the existing
SPDX-FileCopyrightText header line) to include 2026 as the latest year;
specifically modify the header string in
tests/integration/defs/perf/test_perf_sanity.py so the year range reads
2022-2026.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b76c9e91-e666-4f97-b058-33f7fece6d66
📒 Files selected for processing (2)
tests/integration/defs/perf/test_perf_sanity.pytests/integration/test_lists/test-db/l0_gb200_multi_gpus_perf_sanity.yml
|
/bot run --stage "GB200-4_GPUs-PyTorch-PerfSanity-1" |
1 similar comment
|
/bot run --stage "GB200-4_GPUs-PyTorch-PerfSanity-1" |
|
/bot run --help |
|
/bot help |
GitHub Bot Help
Provide a user friendly way for developers to interact with a Jenkins server. Run See details below for each supported subcommand. Details
Launch build/test pipelines. All previously running jobs will be killed.
kill
Kill all running builds associated with pull request. skip
Skip testing for latest commit on pull request. reuse-pipeline
Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break. |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-1" |
|
PR_Github #39396 [ run ] triggered by Bot. Commit: |
|
PR_Github #39398 Bot args parsing error: usage: /bot [-h] |
|
PR_Github #39399 [ run ] triggered by Bot. Commit: |
|
PR_Github #39396 [ run ] completed with state |
|
PR_Github #39399 [ run ] completed with state
|
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-1" |
|
PR_Github #39442 [ run ] triggered by Bot. Commit: |
|
PR_Github #39442 [ run ] completed with state |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-1" |
|
PR_Github #39472 [ run ] triggered by Bot. Commit: |
|
PR_Github #39472 [ run ] completed with state
|
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-1" |
|
PR_Github #39504 [ run ] triggered by Bot. Commit: |
|
PR_Github #39504 [ run ] completed with state |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-PerfSanity-1" |
|
PR_Github #39551 [ run ] triggered by Bot. Commit: |
|
PR_Github #39551 [ run ] completed with state
|
|
/bot run |
|
PR_Github #39568 [ run ] triggered by Bot. Commit: |
Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
Signed-off-by: Eran Geva <19514940+MrGeva@users.noreply.github.com>
MrGeva
force-pushed
the
eg/super_perf_test
branch
from
096fd0e to
621aece
Compare
|
/bot run |
|
PR_Github #39587 [ run ] triggered by Bot. Commit: |
|
PR_Github #39587 [ run ] completed with state |
4 participants
Summary by CodeRabbit
Release Notes
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.